Skip to content

github actions instead of travis ci #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 18, 2021
Merged

Conversation

henrikef
Copy link
Contributor

@henrikef henrikef commented Jan 9, 2021

This implements github actions workflow as already implemented for threeML.

Tests run, but still fail due to known issue #45

Also added check for stale issues and issue templates (bug report, feature request, analysis question)

@grburgess
Copy link
Contributor

Hmm. I cannot see the actions actually running myself.
It looks cool. The only question I have is if it is a good idea to pull the master on 3ML rather than from pip?

I think it its smart to pull the master because this way things will stay in concert between repos if updates are made in both. However, that would mean that someone installing from pip only one of the repos might get different results. Opinon(s)?

@henrikef
Copy link
Contributor Author

Hm. Right now, I'm installing astromodels & threeML from conda in the tests, which is consistent with the recommended installation procedure for hawc_hal. I guess I could add another set of tests using the current master branch of threeML/astromodels instead.

@henrikef henrikef merged commit f250eea into threeML:master Jan 18, 2021
@grburgess
Copy link
Contributor

@henrikef ah... somehow my brain saw that you were installing from the master at GitHub... sorry for the confusion. Must sleep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants