Skip to content

Conversation

@bennystarfighter
Copy link

@bennystarfighter bennystarfighter commented Jan 11, 2025

Build output files should not be tracked in the source repository tree.
This causes issues especially when the plugin is used as a git submodule and changes are recognized just because you've compiled the plugin again.

If its meant as a way to share prebuilt versions for the launcher release of Unreal i can highly recommend tagging and making a github release for the versions instead. Which will let you upload a zip with the packaged version.
Saw that you do use releases.

@andthenwhat
Copy link

Ue55 build version is on the ue55 branch and there are prebuilt 5.5 and 5.4 releases in the releases section

@bennystarfighter
Copy link
Author

You misunderstood my comment. I'm talking about how built binaries should not be a part of the repo but only releases. You check-in compiled versions directly in the git repo.

@andthenwhat
Copy link

andthenwhat commented Mar 21, 2025 via email

@bennystarfighter
Copy link
Author

I think its awesome that this is on GitHub, its a great contribution to the unreal engine open source space so I do not think you should go fab-only. Its easy enough to solve and this PR takes care of removing the files and updating your .gitignore, and your releases with the prebuilt binaries will still be there.

@andthenwhat
Copy link

andthenwhat commented Mar 21, 2025 via email

@threepeatgames threepeatgames added the bug Something isn't working label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants