-
Notifications
You must be signed in to change notification settings - Fork 81
v2.2.0 release candidate #3836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
v2.2.0 release candidate #3836
+411
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atches) for muls critical vulns
Remove all bootstrap node entries from mainnet and testnet peer lists: - Mainnet: Remove bootstrap-b1 and bootstrap-b2 (2 nodes) - Testnet: Remove bootstrap-0, bootstrap-1, and bootstrap-alpha (3 nodes) Keep all participant nodes (Boar and Staked). Network will now rely entirely on participant nodes for peer discovery, eliminating bootstrap infrastructure costs. Remaining peers: - Mainnet: 5 participant nodes (2 Boar + 3 Staked) - Testnet: 2 participant nodes (1 Boar + 1 Staked)
Add workaround flag to main build and abigen commands to bypass runtime.stopTheWorld restrictions in github.com/fjl/memsize package.
Run make generate before go vet and staticcheck to ensure generated contract bindings exist before static analysis.
The client-vet and client-lint jobs should use committed generated contract files rather than attempting to regenerate them, which fails due to missing contract artifacts in CI environment. Restores pkg/chain/ethereum/threshold/gen/ files that were accidentally modified during troubleshooting.
- Create dedicated release.yml workflow triggered by version tags - Builds multi-platform binaries (Linux/macOS AMD64) - Runs tests before release creation - Generates release notes with changelog - Handles pre-releases automatically for tags with hyphens - Updates client.yml to reference new dedicated workflow - Add comprehensive release process documentation Resolves TODO for implementing softprops/action-gh-release automation
- Fix long lines by adding proper line breaks - Add missing newline at end of file - Improve readability while maintaining functionality
Add explanatory comments to gen.go files and .gitignore to document why empty _address files are committed despite being gitignored. This prevents future confusion about the CI build requirements.
The abi/TokenStaking.go, cmd/TokenStaking.go, and contract/TokenStaking.go files were accidentally deleted in ba7a578 when adding the -checklinkname=0 flag. These generated files are committed to the repository and should not have been removed.
… module management Address CodeRabbit finding by removing manual 'go get' commands from Dockerfile that bypass Go module dependency resolution. This eliminates version inconsistencies and makes dependency management transparent and reproducible. Changes: - Remove RUN go get command from Dockerfile (lines 57-58) - Add tools.go with build-time dependencies for Ethereum bindings generation - Update go.mod and go.sum with proper transitive dependencies - Ensure all ethereum/go-ethereum submodule dependencies are tracked - Rely on existing 'go mod download' at line 37 for dependency fetching Dependencies properly managed: - github.com/ferranbt/fastssz (ethereum/go-ethereum/internal/era) - github.com/graph-gophers/graphql-go (ethereum/go-ethereum/graphql) - github.com/influxdata/influxdb-client-go/v2 (ethereum/go-ethereum/metrics) - github.com/influxdata/influxdb1-client (ethereum/go-ethereum/metrics) - github.com/peterh/liner (ethereum/go-ethereum/console/prompt) This ensures module-aware builds work correctly without anti-patterns while maintaining all required functionality for Ethereum contract generation. Resolves: CodeRabbit dependency management anti-pattern finding
Replace double quotes with single quotes in git describe commands to prevent shell parsing errors in GitHub Actions
Vuln Scan Fixes: Closes #3828 All Critical, High and Medium if possible.
## Summary Implements automated GitHub releases triggered by version tags, resolving the TODO for `softprops/action-gh-release` integration. ## Changes - **Release workflow** (`.github/workflows/release.yml`): Tag-triggered automation that builds multi-platform binaries, runs tests, and creates releases with generated notes - **Client workflow update**: Replace TODO with reference to dedicated release workflow - **Documentation** (`docs/release-process.md`): Release guide and troubleshooting ## Usage **Before**: Manual workflow dispatch → download artifacts → create release manually **After**: `git tag v2.1.1 && git push origin v2.1.1` → automated release ## Test Plan 1. Merge PR 2. Test with `v2.1.1-test` tag 3. Create production release with `v2.1.1` tag
## Summary Remove bootstrap node entries from embedded peer lists. Network will rely on existing participant nodes for peer discovery. ## Changes - **Mainnet**: Remove 2 bootstrap nodes (`bootstrap-b1.threshold.p2p.org`, `bootstrap-b2.threshold.p2p.org`) - **Testnet**: Remove 3 bootstrap nodes (`bootstrap-0.test.keep.network`, `bootstrap-1.test.keep.network`, `bootstrap-alpha.test.threshold.p2p.org`) ## Remaining Peers - **Mainnet**: 5 participant nodes (2 Boar + 3 Staked) - **Testnet**: 2 participant nodes (1 Boar + 1 Staked) ## Technical Notes - No code changes - existing libp2p implementation handles any peer type - Participant nodes provide sufficient connectivity for network operation - DNS-based addressing preserved for operational flexibility
evandrosaturnino
previously approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f2cdd96 to
4e11dd7
Compare
13ac2a0 to
4e11dd7
Compare
lrsaturnino
previously approved these changes
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.