feat: self-host cond macro, remove Expr::Cond from compiler - #156
Merged
Conversation
Define cond as a variadic defmacro in the prelude that expands to nested if expressions. Remove Expr::Cond, CondClause, parse_cond, expand_cond, and check_cond from the compiler — cond is no longer a special form. Add macro expansion to typechecker test helper so cond tests work through the full pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
condas a variadicdefmacroinstdlib/prelude.vxthat expands to nestedifexpressionsExpr::Cond,CondClause,parse_cond,expand_cond, andcheck_condfrom the compilercondis no longer a special parser form — it parses as a regular function call and expands via the prelude macrocheck_sourcetest helper so cond-related tests work through the full pipelineNet result: -283 lines, +45 lines — the compiler gets simpler while cond keeps working identically.
Test plan
cargo clippyclean(cond test1 val1 test2 val2 :else default)expands correctly to nested if(cond)with no clauses produces nilexamples/let-and-cond.vxcompiles successfullycond_expressiontest passes end-to-end