-
Notifications
You must be signed in to change notification settings - Fork 22
GraphQL: Fix alias redirects. #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dbosen
wants to merge
25
commits into
7.3.x
Choose a base branch
from
fix/alias-redirects
base: 7.3.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribution into fix/alias-redirects
This reverts commit 4a89652.
8703286
to
9439b82
Compare
While this is being adjusted, I'd like to note that the producer does not URL decode the path argument. So let's say a SEO inserts a redirect:
In some cases, like persisted queries, the path will be URL encoded, since it's passed via GET, this will then lead to a 404 on the URL because the redirect source path does not exist in the database in an encoded form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the thunder_redirect data producer to also redirect from canonical urls to aliases (if the redirect module is configured todo so)