Skip to content

GraphQL: Fix alias redirects. #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: 7.3.x
Choose a base branch
from
Open

GraphQL: Fix alias redirects. #795

wants to merge 25 commits into from

Conversation

dbosen
Copy link
Member

@dbosen dbosen commented May 6, 2024

This fixes the thunder_redirect data producer to also redirect from canonical urls to aliases (if the redirect module is configured todo so)

@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 6, 2024 12:23 Inactive
@dbosen dbosen added test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing labels May 6, 2024
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 6, 2024 12:45 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 6, 2024 13:35 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 6, 2024 14:47 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 6, 2024 15:57 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 6, 2024 16:00 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 10:26 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 10:30 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 10:38 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 11:47 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 15:23 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 15:27 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 15:31 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 15:35 Inactive
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 15:37 Inactive
@dbosen dbosen force-pushed the fix/alias-redirects branch from 8703286 to 9439b82 Compare May 7, 2024 15:44
@ol0lll ol0lll temporarily deployed to thunder-pr-795 May 7, 2024 15:45 Inactive
@dbosen dbosen changed the base branch from 7.2.x to 7.3.x September 4, 2024 14:22
@dbosen dbosen requested a review from IT-Cru September 5, 2024 07:35
@mrmishmash
Copy link
Contributor

While this is being adjusted, I'd like to note that the producer does not URL decode the path argument. So let's say a SEO inserts a redirect:

/wasserdruck-erhöhen -> /wasserdruck-erhoehen

In some cases, like persisted queries, the path will be URL encoded, since it's passed via GET, this will then lead to a 404 on the URL because the redirect source path does not exist in the database in an encoded form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-min Triggers the minimum requirements testing test-upgrade Triggers the upgrade path testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants