fix(acp): wait for settled prompt after Stop; skip SESSION_BUSY auto-retry#1093
Open
metalmon wants to merge 1 commit into
Open
fix(acp): wait for settled prompt after Stop; skip SESSION_BUSY auto-retry#1093metalmon wants to merge 1 commit into
metalmon wants to merge 1 commit into
Conversation
…retry Prevent racing a new session/prompt onto a still-busy ACP slot after cancel, and stop blind chat retries that amplify Zeroclaw's active-turn reject.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session/promptto settle before starting another prompt on the same ACP session, so a quick follow-up send does not race the agent's still-busy turn slot.Fixes #1094
Context
Stop already sends
session/canceland tears down the local SSE stream. Some ACP agents (e.g. Zeroclaw) only clear the busy slot when the cancelled turn fully exits. The UI becomes free immediately, so the next message can hitSession already has an active prompt turnand auto-retry makes it worse.Test plan
bun test src/acp/acp-adapter.test.ts src/lib/error-utils.test.tssession/prompt