remove version check#3516
Draft
5ec1cff wants to merge 2 commits into
Draft
Conversation
Co-authored-by: GitHub Copilot <github-copilot[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the manager↔kernel “version check” warnings and replaces them with simpler UAPI-based compatibility checks, updating the home UI warnings and localization strings accordingly.
Changes:
- Replace version-mismatch + UAPI-mismatch checks with direct
managerUAPIVersionvskernelUAPIVersioncomparisons and new “requiresNewManager” state. - Simplify “update required” strings (remove formatted version numbers) and add a separate “GKI kernel update required” message.
- Centralize “full featured” gating via
Natives.isFullFeatured()and adjust home warning cards (including install tap action only where applicable).
Reviewed changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| manager/app/src/main/res/values/strings.xml | Removes old mismatch strings and replaces formatted “require_*” strings with simplified messages; adds require_kernel_version_gki. |
| manager/app/src/main/res/values-zh-rTW/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-zh-rHK/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-zh-rCN/strings.xml | Removes old mismatch strings; adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-vi/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-uk/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-tr/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-tl/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-th/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-te/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-sr/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-sl/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-ru/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-ro/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-pt/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-pt-rBR/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-pl/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-nl/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-my/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-ms/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-mr/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-lv/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-lt/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-ko/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-kn/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-km/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-ja/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-iw/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-it/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-in/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-hu/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-hr/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-hi/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-gl/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-fr/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-fil/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-fa/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-et/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-es/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-de/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-da/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-bs/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-bn/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-bn-rBD/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-bg/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-az/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/res/values-ar/strings.xml | Adds simplified update-required strings (manager/kernel + GKI variant). |
| manager/app/src/main/java/me/weishu/kernelsu/ui/viewmodel/HomeViewModel.kt | Replaces requireNewKernel/checkUAPIMismatch with UAPI comparisons; introduces requiresNewManager. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/home/HomeUiState.kt | Replaces uapiMismatch with requiresNewManager; removes mismatch-related computed warnings. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/home/HomeMiuix.kt | Reworks warning cards to show simplified update-required messages and optional install tap behavior; removes old mismatch warnings. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/home/HomeMaterial.kt | Same as Miuix: reworks warning cards and removes old mismatch warnings. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/MainActivity.kt | Changes install gating to UAPI equality and uses centralized Natives.isFullFeatured(). |
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/bottombar/NavigationRailMiuix.kt | Switches to Natives.isFullFeatured() gating. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/bottombar/NavigationRailMaterial.kt | Switches to Natives.isFullFeatured() gating. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/bottombar/BottomBarMiuix.kt | Switches to Natives.isFullFeatured() gating. |
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/bottombar/BottomBarMaterial.kt | Switches to Natives.isFullFeatured() gating. |
| manager/app/src/main/java/me/weishu/kernelsu/Natives.kt | Removes requireNewKernel/checkUAPIMismatch; adds isFullFeatured() helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
17
to
19
| val requiresNewKernel: Boolean, | ||
| val uapiMismatch: Boolean, | ||
| val requiresNewManager: Boolean, | ||
| val isRootAvailable: Boolean, |
Comment on lines
109
to
113
| super.onCreate(savedInstanceState) | ||
|
|
||
| val isManager = Natives.isManager | ||
| if (isManager && !Natives.requireNewKernel()) install() | ||
| if (isManager && Natives.kernelUAPIVersion == Natives.managerUAPIVersion) install() | ||
|
|
Comment on lines
30
to
34
| @Composable | ||
| fun BottomBarMaterial() { | ||
| val isManager = Natives.isManager | ||
| val fullFeatured = isManager && !Natives.requireNewKernel() && rootAvailable() | ||
| val fullFeatured = Natives.isFullFeatured() | ||
| val mainPagerState = LocalMainPagerState.current | ||
|
|
Comment on lines
45
to
50
| blurBackdrop: LayerBackdrop?, | ||
| backdrop: Backdrop, | ||
| modifier: Modifier, | ||
| ) { | ||
| val isManager = Natives.isManager | ||
| val fullFeatured = isManager && !Natives.requireNewKernel() && rootAvailable() | ||
| val fullFeatured = Natives.isFullFeatured() | ||
| if (!fullFeatured) return |
Comment on lines
33
to
37
| fun NavigationRailMaterial( | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val isManager = Natives.isManager | ||
| val fullFeatured = isManager && !Natives.requireNewKernel() && rootAvailable() | ||
| val fullFeatured = Natives.isFullFeatured() | ||
| val mainPagerState = LocalMainPagerState.current |
Comment on lines
20
to
26
| @Composable | ||
| fun NavigationRailMiuix( | ||
| blurBackdrop: LayerBackdrop?, | ||
| modifier: Modifier = Modifier, | ||
| ) { | ||
| val isManager = Natives.isManager | ||
| val fullFeatured = isManager && !Natives.requireNewKernel() && rootAvailable() | ||
| val fullFeatured = Natives.isFullFeatured() | ||
| if (!fullFeatured) return |
Comment on lines
8
to
11
| <string name="home_working_version">Version: %s</string> | ||
| <string name="home_unsupported">Unsupported</string> | ||
| <string name="home_unsupported_reason">KernelSU only supports GKI kernels now, but you can patch the image for GKI devices.</string> | ||
| <string name="home_version_mismatch">Manager version (%1$d) and KernelSU driver version (%2$d) mismatch.</string> | ||
| <string name="home_device_model">Device model</string> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.