Skip to content

fix(ios): removed unsupported title property #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): removed unsupported title property #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ In order to use the `close` event on Android it is recommended to have a short d
* `animated` (Boolean, iOS only)
* `entersReaderIfAvailable` (Boolean, iOS only)
* `barCollapsingEnabled` (Boolean)
* `title` (String, iOS only)
* `tintColor` (String, iOS only)
   * `dismissButtonStyle` (`DISMISS_BUTTON_STYLE_*`, iOS only)
* `showTitle` (Boolean, Android only)
Expand Down
11 changes: 2 additions & 9 deletions apidoc/WebDialog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ description: |
``` javascript
if (dialog.isSupported()) {
dialog.open({
url: 'https://appcelerator.com'
url: 'https://titaniumsdk.com'
});
}
```
Expand Down Expand Up @@ -92,8 +92,7 @@ methods:
var dialog = require('ti.webdialog');
if (dialog.isSupported()) {
dialog.open({
url: 'https://appcelerator.com',
title: 'Hello World',
url: 'https://titaniumsdk.com',
tintColor: 'red'
});
}
Expand Down Expand Up @@ -170,12 +169,6 @@ properties:
type: Boolean
platforms: [iphone, ipad]

- name: title
summary: The URL to be opened.
optional: true
type: String
platforms: [iphone, ipad]

- name: tintColor
summary: The tint-color of the web dialog.
optional: true
Expand Down
4 changes: 0 additions & 4 deletions ios/Classes/TiWebdialogModule.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,6 @@ - (void)open:(id)args

SFSafariViewController *safari = [self safariController:_url withEntersReaderIfAvailable:entersReaderIfAvailable andBarCollapsingEnabled:barCollapsingEnabled];

if ([args objectForKey:@"title"]) {
[safari setTitle:[TiUtils stringValue:@"title" properties:args]];
}

if ([args objectForKey:@"tintColor"]) {
TiColor *newColor = [TiUtils colorValue:@"tintColor" properties:args];
[safari setPreferredControlTintColor:[newColor _color]];
Expand Down