using compat-lifecycle #4036
using compat-lifecycle #4036
Conversation
|
I think it's too harsh to deprecate the underscore functions without a soft-deprecation cycle. Also should we retire them instead of soft-deprecating them? i.e. maintain these functions undefinitely as long as they are not a maintenance burden. |
|
Were they not soft deprecated already ? |
Not in the compat-lifecycle sense. They did not warn users calling from the global env nor developers testing their packages. These soft warnings are meant to ease the deprecation process. |
|
I see. I'll move them to soft deprecated then. Does that mean #4043 should be reopen ? |
|
No, because they are soft deprecated, and we should be steering people away from them. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
@lionel- would you have a look please ?