Skip to content

Polishes triggered by revdep failures #6506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/guide-colorsteps.R
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ GuideColoursteps <- ggproto(
params$title <- scale$make_title(params$title, scale$name, title)

limits <- c(params$decor$min[1], params$decor$max[nrow(params$decor)])
if (params$reverse) {
if (isTRUE(params$reverse)) {
limits <- rev(limits)
}
params$key$.value <- rescale(params$key$.value, from = limits)
Expand Down
2 changes: 1 addition & 1 deletion R/position-dodge.R
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ PositionDodge <- ggproto("PositionDodge", Position,
data$order <- xtfrm( # xtfrm makes anything 'sortable'
data$order %||% ave(data$group, data$x, data$PANEL, FUN = match_sorted)
)
if (params$reverse) {
if (isTRUE(params$reverse)) {
data$order <- -data$order
}
if (is.null(params$n)) { # preserve = "total"
Expand Down
12 changes: 6 additions & 6 deletions R/theme.R
Original file line number Diff line number Diff line change
Expand Up @@ -518,9 +518,9 @@
)
if (is.null(elements[["legend.title"]])) {
elements$legend.title <- element_text(hjust = elements$legend.title.align)
} else {
elements$legend.title$hjust <- elements$legend.title$hjust %||%
elements$legend.title.align
} else if (!is_theme_element(elements$legend.title, "blank")) {
elements$legend.title$hjust <-
try_prop(elements$legend.title, "hjust", elements$legend.title.align)

Check warning on line 523 in R/theme.R

View check run for this annotation

Codecov / codecov/patch

R/theme.R#L521-L523

Added lines #L521 - L523 were not covered by tests
}
elements$legend.title.align <- NULL
}
Expand All @@ -531,9 +531,9 @@
)
if (is.null(elements[["legend.text"]])) {
elements$legend.text <- element_text(hjust = elements$legend.text.align)
} else {
elements$legend.text$hjust <- elements$legend.text$hjust %||%
elements$legend.text.align
} else if (!is_theme_element(elements$legend.text, "blank")) {
elements$legend.text$hjust <-
try_prop(elements$legend.text, "hjust", elements$legend.text.align)

Check warning on line 536 in R/theme.R

View check run for this annotation

Codecov / codecov/patch

R/theme.R#L534-L536

Added lines #L534 - L536 were not covered by tests
}
elements$legend.text.align <- NULL
}
Expand Down