Revert "fix: check kill signal against 0 (#1102)" #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 057c479. Signed-off-by: MyonKeminta <[email protected]>
MyonKeminta
force-pushed
the
m/revert-1102
branch
from
a8368b3 to
f1a1f5e
Compare
MyonKeminta
requested review from
cfzjywxk and
ekexium
and removed request for
cfzjywxk
cfzjywxk
approved these changes
Jan 23, 2024
ekexium
approved these changes
Jan 23, 2024
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Jan 29, 2024
)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]>
cfzjywxk
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 18, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
cfzjywxk
added a commit
that referenced
this pull request
Feb 19, 2024
* feat: check kill signal in 2pc committer (#1084) Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
ekexium
added a commit
to ekexium/client-go
that referenced
this pull request
Feb 27, 2024
* feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
ekexium
added a commit
that referenced
this pull request
Feb 27, 2024
* fix: check kill signal against 0 (#1102) * fix: check kill signal against 0, so that all kill signals will not be ignored. Signed-off-by: ekexium <[email protected]> * refactor: extract method checkKilled() Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]> * ErrQueryInterrupted with parameters (#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (#1102)" (#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]> * rm backoff.go Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]>
zeminzhou
pushed a commit
to zeminzhou/client-go
that referenced
this pull request
Feb 28, 2024
* feat: check kill signal in 2pc committer (tikv#1084) Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> * ErrQueryInterrupted with parameters (tikv#1124) * feat: ErrQueryInterrupted with parameters Signed-off-by: ekexium <[email protected]> * Revert "Revert "fix: check kill signal against 0 (tikv#1102)" (tikv#1129)" This reverts commit 3480b5e. Signed-off-by: ekexium <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: cfzjywxk <[email protected]> --------- Signed-off-by: ekexium <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]> Signed-off-by: zzm <[email protected]>
iosmanthus
pushed a commit
that referenced
this pull request
Mar 13, 2024
Co-authored-by: zzm <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: ekexium <[email protected]> Co-authored-by: Yongbo Jiang <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Evan Zhou <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: Ryan Leung <[email protected]> Co-authored-by: jinhelin <[email protected]> Co-authored-by: iosmanthus <[email protected]> Co-authored-by: Ping Yu <[email protected]> fix: check kill signal against 0 (#1102)" (#1129)" fix safepoint kv with keyspace name (#928) fix encoding of mvcc get by key (#775) close on canceled (#1121) Fix wait recvloop timeout (#1134) CloseAddr (#1140) Fix timeout of TestResolveTxnFallbackFromAsyncCommit (#1146)
iosmanthus
added a commit
that referenced
this pull request
Jul 9, 2024
Co-authored-by: zzm <[email protected]> Co-authored-by: glorv <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: cfzjywxk <[email protected]> Co-authored-by: ShuNing <[email protected]> Co-authored-by: ekexium <[email protected]> Co-authored-by: Liqi Geng <[email protected]> Co-authored-by: zyguan <[email protected]> Co-authored-by: xufei <[email protected]> Co-authored-by: crazycs <[email protected]> fix: check kill signal against 0 (#1102)" (#1129)" fix #1111 (#1324) fix rpc client panic cause by concurrent close (#1358)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily revert #1102 to avoid test failures on TiDB repo.
This would be fixed by #1124 later.