-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdclient: Add caller info to pd client #1516
Open
okJiang
wants to merge
8
commits into
tikv:master
Choose a base branch
from
okJiang:add-pd-caller
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+38
−10
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
785a707
update call component
okJiang c2772ea
Merge branch 'master' into add-pd-caller
okJiang 2485ba4
add implement
okJiang 321e73a
Merge branch 'master' into add-pd-caller
okJiang 505ec3a
Merge branch 'master' of github.com:tikv/client-go into add-pd-caller
okJiang 76211fe
fix ut
okJiang ecb6b8e
fix ut
okJiang 5376b07
fix comment
okJiang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,6 +44,7 @@ import ( | |
"github.com/tikv/pd/client/clients/router" | ||
"github.com/tikv/pd/client/clients/tso" | ||
"github.com/tikv/pd/client/opt" | ||
"github.com/tikv/pd/client/pkg/caller" | ||
) | ||
|
||
var ( | ||
|
@@ -64,6 +65,10 @@ type InterceptedPDClient struct { | |
pd.Client | ||
} | ||
|
||
func NewInterceptedPDClient(client pd.Client) *InterceptedPDClient { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. needs comment for public. |
||
return &InterceptedPDClient{client.WithCallerComponent("intercepted-pd-client")} | ||
} | ||
|
||
// interceptedTsFuture is a PD's wrapper future to record stmt detail. | ||
type interceptedTsFuture struct { | ||
tso.TSFuture | ||
|
@@ -137,3 +142,8 @@ func (m InterceptedPDClient) GetStore(ctx context.Context, storeID uint64) (*met | |
recordPDWaitTime(ctx, start) | ||
return s, err | ||
} | ||
|
||
// WithCallerComponent implements pd.Client#WithCallerComponent. | ||
func (m InterceptedPDClient) WithCallerComponent(component caller.Component) pd.Client { | ||
return NewInterceptedPDClient(m.Client.WithCallerComponent(component)) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about defining and describing one enum not using string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about defining them in pd repo? If you agree, I can open a pr to do it.