Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tidb-8.5) Use global txn scope when validating ts #1583

Merged

Conversation

ekexium
Copy link
Contributor

@ekexium ekexium commented Feb 17, 2025

This is to reduce the risk of txn-scope related bugs.

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
@ekexium ekexium requested review from you06 and MyonKeminta February 17, 2025 06:04
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 17, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 18, 2025
Copy link

ti-chi-bot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MyonKeminta, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 18, 2025
Copy link

ti-chi-bot bot commented Feb 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-17 07:30:01.563729486 +0000 UTC m=+860043.959951548: ☑️ agreed by MyonKeminta.
  • 2025-02-18 01:46:47.728464409 +0000 UTC m=+925850.124686470: ☑️ agreed by you06.

@ti-chi-bot ti-chi-bot bot merged commit 7da5131 into tikv:tidb-8.5 Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants