Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hhwyt to tikv reviewers list #227

Merged
merged 1 commit into from
Feb 14, 2025
Merged

add hhwyt to tikv reviewers list #227

merged 1 commit into from
Feb 14, 2025

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Feb 14, 2025

#226 has nominated @hhwyt as tikv reviewer but forget to add him to the team member list.

Copy link

ti-chi-bot bot commented Feb 14, 2025

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Feb 14, 2025
@glorv glorv changed the title add hhwyt to tikv members add hhwyt to tikv reviewers list Feb 14, 2025
Copy link

ti-chi-bot bot commented Feb 14, 2025

@Connor1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2025
@rleungx rleungx merged commit 6dae947 into tikv:master Feb 14, 2025
3 of 4 checks passed
@glorv glorv deleted the add-hhwyt branch February 14, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants