Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: speed up exit #5340

Closed
wants to merge 1 commit into from

Conversation

han-ian
Copy link

@han-ian han-ian commented Jul 21, 2022

What problem does this PR solve?

Issue Number: Close #5274

What is changed and how does it work?

     if coordinator's ctx has been closed, don't do more schedule. 

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    For our cluster with more than 2000 tikv-servers, pd transfer leader can be done in 1 second.

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

speed up scheduler exit  

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 21, 2022
@ti-chi-bot ti-chi-bot requested review from nolouch and rleungx July 21, 2022 10:20
@han-ian han-ian closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coordinator can't stop in time, because of background jobs are still running
2 participants