-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schedulers: opt balance witness when store nr larger than peer nr #6149
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6149 +/- ##
==========================================
- Coverage 74.41% 74.40% -0.02%
==========================================
Files 391 392 +1
Lines 38175 38316 +141
==========================================
+ Hits 28409 28510 +101
- Misses 7241 7283 +42
+ Partials 2525 2523 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 37 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@@ -91,6 +91,27 @@ func (bc *BasicCluster) GetNonWitnessVoterStores(region *RegionInfo) []*StoreInf | |||
return Stores | |||
} | |||
|
|||
// GetOptionalStoresForRegion returns all Stores that can be used to store the region's peer. | |||
func (bc *BasicCluster) GetOptionalStoresForRegion(region *RegionInfo) []*StoreInfo { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about add new filter for this store? like excludedFilter
.
ref tikv#5762 Signed-off-by: Wenbo Zhang <[email protected]>
Signed-off-by: Wenbo Zhang <[email protected]>
Signed-off-by: Wenbo Zhang <[email protected]>
Signed-off-by: Wenbo Zhang <[email protected]>
Signed-off-by: Wenbo Zhang <[email protected]>
751843e
to
0c4a8c8
Compare
Signed-off-by: Wenbo Zhang <[email protected]>
Signed-off-by: Wenbo Zhang <[email protected]>
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ref #5762
What problem does this PR solve?
Issue Number: ref #5762
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Release note