Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs, tso: create global tso state view and apply to discovery, monitoring, etc. #6525

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

binshi-bing
Copy link
Contributor

What problem does this PR solve?

Issue Number: Ref #5895

What is changed and how does it work?

Add registered TSO server watch loop to the TSO microservice

Check List

Tests

  • Unit test
None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 25, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 25, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx May 25, 2023 23:53
@binshi-bing binshi-bing marked this pull request as draft May 25, 2023 23:53
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2023
@binshi-bing binshi-bing requested a review from JmPotato May 25, 2023 23:54
@binshi-bing binshi-bing changed the title mcs, tso: create global tso state view for discovery, monitoring, etc. mcs, tso: create global tso state view and apply to discovery, monitoring, etc. May 25, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Attention: Patch coverage is 76.47059% with 12 lines in your changes missing coverage. Please review.

Project coverage is 74.60%. Comparing base (6afbcec) to head (40b75d9).
Report is 799 commits behind head on master.

Files Patch % Lines
pkg/tso/keyspace_group_manager.go 75.51% 9 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6525      +/-   ##
==========================================
+ Coverage   74.57%   74.60%   +0.02%     
==========================================
  Files         417      417              
  Lines       42896    42949      +53     
==========================================
+ Hits        31990    32040      +50     
+ Misses       8079     8078       -1     
- Partials     2827     2831       +4     
Flag Coverage Δ
unittests 74.60% <76.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binshi-bing binshi-bing force-pushed the tso-global-state-view branch 3 times, most recently from 868b2e9 to ab3e2a4 Compare May 26, 2023 08:33
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2023
@binshi-bing binshi-bing force-pushed the tso-global-state-view branch from ab3e2a4 to 421e2d2 Compare June 15, 2023 23:19
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 15, 2023
@binshi-bing binshi-bing force-pushed the tso-global-state-view branch from 421e2d2 to 40b75d9 Compare June 15, 2023 23:31
@ti-chi-bot ti-chi-bot bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant