Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: support tidb-operator SDK #7508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Dec 7, 2023

What problem does this PR solve?

Issue Number: Ref #7300

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 7, 2023
@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx December 7, 2023 09:27
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 7, 2023
@HuSharp HuSharp force-pushed the support_operator_http branch from 5e09966 to 3d6bb5a Compare December 7, 2023 09:32
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the support_operator_http branch from 3d6bb5a to 9ada30d Compare December 8, 2023 07:10
return true, nil
}

func (c *client) DeleteStore(ctx context.Context, storeID uint64) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to group the Interface by severity. some interfaces are only used in operators and it's critical. Once user use this function, should let the user know it's critical when using that. like the group the op interface to the MaintianceOpClient etc.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants