-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/http: support tidb-operator SDK #7508
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
5e09966
to
3d6bb5a
Compare
Signed-off-by: husharp <[email protected]>
3d6bb5a
to
9ada30d
Compare
return true, nil | ||
} | ||
|
||
func (c *client) DeleteStore(ctx context.Context, storeID uint64) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to group the Interface by severity. some interfaces are only used in operators and it's critical. Once user use this function, should let the user know it's critical when using that. like the group the op interface to the MaintianceOpClient
etc.
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
Issue Number: Ref #7300
What is changed and how does it work?
Check List
Tests
Release note