checker, statistic: avoid leak in label statistic #8703

lhy1024 · 2024-10-14T15:18:45Z

What problem does this PR solve?

Issue Number: Close #8700

What is changed and how does it work?

Check List

Tests

Unit test

Release note

None.

Signed-off-by: lhy1024 <[email protected]>

codecov · 2024-10-14T15:27:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (48e72f1) to head (1324449).
Report is 119 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8703      +/-   ##
==========================================
+ Coverage   71.70%   71.71%   +0.01%     
==========================================
  Files         517      517              
  Lines       67450    67466      +16     
==========================================
+ Hits        48364    48383      +19     
+ Misses      15521    15512       -9     
- Partials     3565     3571       +6

Flag	Coverage Δ
unittests	`71.71% <100.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

pkg/schedule/checker/checker_controller.go

Signed-off-by: lhy1024 <[email protected]>

rleungx · 2024-10-15T08:23:54Z

pkg/statistics/region_collection.go

+
+// ClearDefunctRegions is used to handle the overlap region.
+// It is used to remove the defunct regions from the label statistics.
+func (l *LabelStatistics) ClearDefunctRegions() {


How about adding a unit test?

ok, I have added a unit test, which can pass in this pr and is failed in master branch.

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot · 2024-10-16T07:13:42Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ti-chi-bot · 2024-10-16T07:13:43Z

[LGTM Timeline notifier]

Timeline:

2024-10-15 10:13:14.052296332 +0000 UTC m=+352391.201206161: ☑️ agreed by okJiang.
2024-10-16 07:13:42.726059788 +0000 UTC m=+428019.874969620: ☑️ agreed by rleungx.

lhy1024 · 2024-10-16T07:19:45Z

/check-issue-triage-complete

lhy1024 · 2024-10-16T07:22:50Z

/check-issue-triage-complete

lhy1024 · 2024-10-22T03:49:56Z

/cherry-pick release-8.4

ti-chi-bot · 2024-10-22T03:50:56Z

@lhy1024: new pull request created to branch release-8.4: #8735.

In response to this:

/cherry-pick release-8.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #8700 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]>

ti-chi-bot · 2024-10-30T02:41:38Z

In response to a cherrypick label: new pull request created to branch release-7.1: #8751.

close tikv#8700 Signed-off-by: ti-chi-bot <[email protected]>

Signed-off-by: lhy1024 <[email protected]>

close #8700 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close tikv#8700 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot · 2024-12-05T06:35:59Z

In response to a cherrypick label: new pull request created to branch release-7.5: #8872.

close #8700 Signed-off-by: ti-chi-bot <[email protected]> Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

close tikv#8700 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot · 2024-12-11T08:03:47Z

In response to a cherrypick label: new pull request created to branch release-8.1: #8898.

close #8700 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

ti-chi-bot · 2025-01-26T07:39:05Z

In response to a cherrypick label: new pull request created to branch release-6.5: #9024.

close tikv#8700 Signed-off-by: ti-chi-bot <[email protected]>

) close tikv#8700 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: lhy1024 <[email protected]>

checker, statistic: avoid leak in label statistic

91da17a

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 14, 2024

rleungx reviewed Oct 15, 2024

View reviewed changes

pkg/schedule/checker/checker_controller.go Outdated Show resolved Hide resolved

address comments

36845fa

Signed-off-by: lhy1024 <[email protected]>

rleungx reviewed Oct 15, 2024

View reviewed changes

add unit test

7075c58

Signed-off-by: lhy1024 <[email protected]>

okJiang approved these changes Oct 15, 2024

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 15, 2024

lhy1024 requested a review from rleungx October 16, 2024 06:47

rleungx approved these changes Oct 16, 2024

View reviewed changes

ti-chi-bot bot added the lgtm label Oct 16, 2024

ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 16, 2024

ti-chi-bot bot removed the do-not-merge/needs-triage-completed label Oct 16, 2024

ti-chi-bot bot added 2 commits October 16, 2024 07:23

Merge branch 'master' into fix-label-leak

5de15e8

Merge branch 'master' into fix-label-leak

1324449

ti-chi-bot bot merged commit 26123dc into tikv:master Oct 16, 2024
24 of 25 checks passed

lhy1024 deleted the fix-label-leak branch October 22, 2024 03:50

ti-chi-bot mentioned this pull request Oct 22, 2024

checker, statistic: avoid leak in label statistic (#8703) #8735

Merged

ti-chi-bot bot pushed a commit that referenced this pull request Oct 22, 2024

checker, statistic: avoid leak in label statistic (#8703) (#8735)

fc6e45c

close #8700 Signed-off-by: lhy1024 <[email protected]> Co-authored-by: lhy1024 <[email protected]>

ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 30, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Oct 30, 2024

This is an automated cherry-pick of tikv#8703

af7e9c3

close tikv#8700 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Oct 30, 2024

checker, statistic: avoid leak in label statistic (#8703) #8751

Merged

lhy1024 added a commit to ti-chi-bot/pd that referenced this pull request Oct 30, 2024

checker, statistic: avoid leak in label statistic (tikv#8703) tikv#8751

1cfc300

Signed-off-by: lhy1024 <[email protected]>

ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 5, 2024

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Dec 5, 2024

This is an automated cherry-pick of tikv#8703

5538f7a

close tikv#8700 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Dec 5, 2024

checker, statistic: avoid leak in label statistic (#8703) #8872

Merged

ti-chi-bot bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Dec 11, 2024

ti-chi-bot mentioned this pull request Dec 11, 2024

checker, statistic: avoid leak in label statistic (#8703) #8898

Merged

ti-chi-bot bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Jan 26, 2025

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jan 26, 2025

This is an automated cherry-pick of tikv#8703

2aab15c

close tikv#8700 Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Jan 26, 2025

checker, statistic: avoid leak in label statistic (#8703) #9024

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

checker, statistic: avoid leak in label statistic #8703

checker, statistic: avoid leak in label statistic #8703

lhy1024 commented Oct 14, 2024

codecov bot commented Oct 14, 2024 •

edited

Loading

rleungx Oct 15, 2024

lhy1024 Oct 15, 2024

ti-chi-bot bot commented Oct 16, 2024

ti-chi-bot bot commented Oct 16, 2024

lhy1024 commented Oct 16, 2024

lhy1024 commented Oct 16, 2024

lhy1024 commented Oct 22, 2024

ti-chi-bot commented Oct 22, 2024

ti-chi-bot commented Oct 30, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 11, 2024

ti-chi-bot commented Jan 26, 2025

checker, statistic: avoid leak in label statistic #8703

checker, statistic: avoid leak in label statistic #8703

Conversation

lhy1024 commented Oct 14, 2024

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

codecov bot commented Oct 14, 2024 • edited Loading

Codecov Report

rleungx Oct 15, 2024

Choose a reason for hiding this comment

lhy1024 Oct 15, 2024

Choose a reason for hiding this comment

ti-chi-bot bot commented Oct 16, 2024

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

lhy1024 commented Oct 16, 2024

lhy1024 commented Oct 16, 2024

lhy1024 commented Oct 22, 2024

ti-chi-bot commented Oct 22, 2024

ti-chi-bot commented Oct 30, 2024

ti-chi-bot commented Dec 5, 2024

ti-chi-bot commented Dec 11, 2024

ti-chi-bot commented Jan 26, 2025

codecov bot commented Oct 14, 2024 •

edited

Loading