Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: support pyroscope for continous profile #8958

Merged
merged 23 commits into from
Feb 24, 2025

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Dec 30, 2024

What problem does this PR solve?

Issue Number: Close #8957

What is changed and how does it work?

Check List

Tests

Code changes

Side effects

  • Possible performance regression

Related changes

Release note

None.

Signed-off-by: 童剑 <[email protected]>
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 30, 2024
Signed-off-by: 童剑 <[email protected]>
@bufferflies bufferflies marked this pull request as ready for review December 30, 2024 07:18
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@bufferflies bufferflies changed the title support pyroscope metrics: support pyroscope for continous profile Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (a5c1101) to head (b3f8f2d).
Report is 1 commits behind head on master.

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8958      +/-   ##
==========================================
- Coverage   76.37%   76.30%   -0.07%     
==========================================
  Files         468      468              
  Lines       71708    71729      +21     
==========================================
- Hits        54767    54734      -33     
- Misses      13520    13564      +44     
- Partials     3421     3431      +10     
Flag Coverage Δ
unittests 76.30% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

format
Signed-off-by: 童剑 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 15, 2025
@bufferflies
Copy link
Contributor Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2025

@bufferflies: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies
Copy link
Contributor Author

@okJiang ptal again

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 17, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 17, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-15 08:15:11.117250546 +0000 UTC m=+106382.572296695: ☑️ agreed by nolouch.
  • 2025-01-17 07:58:13.23168731 +0000 UTC m=+278164.686733460: ☑️ agreed by okJiang.

ti-chi-bot bot added 2 commits February 8, 2025 09:16

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ti-chi-bot bot added 9 commits February 10, 2025 09:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bufferflies
Copy link
Contributor Author

/retest

@bufferflies
Copy link
Contributor Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Feb 17, 2025

@bufferflies: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: Proposal: Strengthen configuration change approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@bufferflies
Copy link
Contributor Author

/test pull-integration-realcluster-test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bufferflies
Copy link
Contributor Author

/retest

@bufferflies
Copy link
Contributor Author

/test pull-integration-realcluster-test

2 similar comments
@bufferflies
Copy link
Contributor Author

/test pull-integration-realcluster-test

@bufferflies
Copy link
Contributor Author

/test pull-integration-realcluster-test

ti-chi-bot bot added 8 commits February 18, 2025 09:54

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ti-chi-bot ti-chi-bot bot merged commit 6504311 into tikv:master Feb 24, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support pyroscope for golang runtime analyze
4 participants