Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tso: add retry for UpdateTSO #9021

Merged
merged 5 commits into from
Feb 5, 2025
Merged

tso: add retry for UpdateTSO #9021

merged 5 commits into from
Feb 5, 2025

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jan 26, 2025

What problem does this PR solve?

Issue Number: Close #9020

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Before:
    image
    After:
    image

Release note

None.

@lhy1024 lhy1024 requested a review from rleungx January 26, 2025 03:24
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2025
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.24%. Comparing base (dcb426b) to head (ebbb024).
Report is 1428 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9021      +/-   ##
==========================================
+ Coverage   75.54%   76.24%   +0.69%     
==========================================
  Files         332      467     +135     
  Lines       33892    71113   +37221     
==========================================
+ Hits        25604    54218   +28614     
- Misses       6082    13510    +7428     
- Partials     2206     3385    +1179     
Flag Coverage Δ
unittests 76.24% <100.00%> (+0.69%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 5, 2025
pkg/tso/global_allocator.go Outdated Show resolved Hide resolved
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 5, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 5, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-05 02:58:33.033534029 +0000 UTC m=+240584.565946028: ☑️ agreed by nolouch.
  • 2025-02-05 07:33:01.936845935 +0000 UTC m=+257053.469257934: ☑️ agreed by rleungx.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 5, 2025

I will test it with new commit

@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 5, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 5, 2025

@lhy1024 lhy1024 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2025
@ti-chi-bot ti-chi-bot bot merged commit ac4e640 into tikv:master Feb 5, 2025
25 checks passed
@lhy1024 lhy1024 deleted the etcd-keep branch February 5, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected election when one of followers is network partition with leader
3 participants