reset max_apply_unpersisted_log_limit in become_follower #561
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Connor1996 @overvenus @gengliqi PTAL, thanks~ |
Connor1996
reviewed
Feb 20, 2025
Signed-off-by: glorv <[email protected]>
glorv
force-pushed
the
reset-on-follower
branch
from
4247a6a to
09742ec
Compare
Signed-off-by: glorv <[email protected]>
glorv
force-pushed
the
reset-on-follower
branch
from
943a840 to
d5a0e2c
Compare
Open
9 tasks
hhwyt
reviewed
Feb 21, 2025
src/raft.rs
Outdated
| @@ -1152,6 +1152,12 @@ impl<T: Storage> Raft<T> { | |||
| let from_role = self.state; | |||
| self.state = StateRole::Follower; | |||
| self.pending_request_snapshot = pending_request_snapshot; | |||
| // TODO: In theory, we should better control this in the caller, | |||
Signed-off-by: glorv <[email protected]>
|
@Connor1996 @hhwyt PTAL again |
|
@overvenus PTAL |
hbisheng
reviewed
Feb 24, 2025
|
Would you mind putting down some context in the PR description? Otherwise it might not be obvious to future readers that this change is part of tikv/tikv#18241. |
Co-authored-by: Bisheng Huang <[email protected]> Signed-off-by: glorv <[email protected]>
overvenus
reviewed
Feb 25, 2025
|
|
||
| for _ in 0..=sm.election_timeout() { | ||
| sm.tick(); | ||
| } | ||
|
|
||
| assert_eq!(sm.state, StateRole::Follower); | ||
| // check after become follower, the limit is reset. |
There was a problem hiding this comment.
Please add some comments explaining why the reset is necessary.
There was a problem hiding this comment.
Done. PTAL again, thanks
Signed-off-by: glorv <[email protected]>
…to reset-on-follower
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reset the
max_apply_unpersisted_log_limitvalue when peer role demote from leader to follower. Because the user can only notice role change event after callready()and the committed entries are collected in theready()so we have to do this here to ensure we only enablemax_apply_unpersisted_log_limiton raft leader.NOTE: In theory, the affect of
max_apply_unpersisted_log_limitis not related the raft role. We limit it to only leader to prevent potencial corn cases. We may want to remove this restriction in the future. In that case, we should revert this PR then.See tikv/tikv#17868 for more details.