Skip to content

fix: cleanup docs and error messages #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahammond merged 1 commit into from
Feb 21, 2025
Merged

fix: cleanup docs and error messages #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ You will need a GH PAT with the following scopes (at a minimum):

- `repo` Full control of private repositories

## Special Cases

Setting the `majorVersion` to `all` will support the renovate `all non-major dependencies` updates.

Setting the `majorVersion` to `projen` will support the `projen` native `update-projen-main` workflows.

In these special cases, the `--library` option is ignored and the `--maxAgeDays` parameter comes into play.

## TODO

- detect and address case where PR is not up-to-date with base branch.
Expand Down
8 changes: 4 additions & 4 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,17 +259,17 @@ export async function script(
);

// Find the update-main workflow,
const workflowPath = `.github/workflows/${workflowName}.yml`;
const workflows = await octokit.paginate(
'GET /repos/{owner}/{repo}/actions/workflows',
{ ...baseParams, per_page: 100 },
(response) => response.data
);
const renovateWf = workflows.find(
(w) => w.path === `.github/workflows/${workflowName}.yml`
);
const renovateWf = workflows.find((w) => w.path === workflowPath);
// octokit.log.info(JSON.stringify(renovateWf));
if (renovateWf === undefined) {
octokit.log.error('Missing upgrade-main / renovate.yml workflow!');
octokit.log.error(`Missing workflow at ${workflowPath}`);
return;
}
const workflow_id = renovateWf?.id ?? 0; // Should never be 0, but...

Expand Down