Skip to content

Improve instructions for self-hosted Postgres live-sync #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jun 27, 2025
Merged

Improve instructions for self-hosted Postgres live-sync #4235

merged 15 commits into from
Jun 27, 2025

Conversation

arajkumar
Copy link
Member

@arajkumar arajkumar commented Jun 25, 2025 •
edited
Loading

Description

[Short summary of why you created this PR]

Links

Fixes https://linear.app/timescale/issue/CON-831/improve-self-hosted-livesync-documentation

Writing help

For information about style and word usage, see the Contribution guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@arajkumar arajkumar requested a review from billy-the-fish June 25, 2025 05:42
@github-actions GitHub Actions
Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-arajkumar-refator-lm-instr

@arajkumar arajkumar requested a review from JamesGuthrie June 25, 2025 05:43
@arajkumar arajkumar changed the title livesync-pg: Refactor steps and add instructions to view lag livesync-pg: Refactor steps and add instructions to view replication lag Jun 25, 2025
billy-the-fish
billy-the-fish requested changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc, couple of things to achieve total awesomeness.

JamesGuthrie
JamesGuthrie approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@JamesGuthrie JamesGuthrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor copy suggestions, otherwise LGTM

arajkumar and others added 6 commits June 26, 2025 19:04
@arajkumar @billy-the-fish
Update _partials/_livesync-terminal.md
7ece78f 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar @billy-the-fish
Update _partials/_livesync-terminal.md
7d5a5b7 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar @billy-the-fish
Update _partials/_livesync-terminal.md
f5ad2f6 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar @billy-the-fish
Apply suggestions from code review
90b1abe 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar @billy-the-fish
Apply suggestions from code review
2cc9880 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar
apply review comments
31cc9a1 
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar arajkumar requested a review from billy-the-fish June 27, 2025 07:36
@arajkumar
Copy link
Member Author

@billy-the-fish Applied your suggestions. PTAL

@arajkumar
refer v0.1.17
a30290e 
Signed-off-by: Arunprasad Rajkumar <[email protected]>
billy-the-fish
billy-the-fish approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@billy-the-fish billy-the-fish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arajkumar, nice stuff. Approved with a couple of small suggestions.

billy-the-fish and others added 4 commits June 27, 2025 11:00
@billy-the-fish
Merge branch 'latest' into arajkumar/refator-lm-instr
9469e36
@arajkumar @billy-the-fish
Update _partials/_livesync-console.md
addb3c0 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar @billy-the-fish
Update _partials/_livesync-console.md
61720bc 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar @billy-the-fish
Apply suggestions from code review
c80157c 
Co-authored-by: Iain Cox <[email protected]>
Signed-off-by: Arunprasad Rajkumar <[email protected]>
@arajkumar arajkumar changed the title livesync-pg: Refactor steps and add instructions to view replication lag Improve instructions for self-hosted Postgres live-sync Jun 27, 2025
@arajkumar arajkumar requested a review from billy-the-fish June 27, 2025 10:10
@arajkumar
Copy link
Member Author

arajkumar commented Jun 27, 2025 •
edited
Loading

Thanks @billy-the-fish ! I've accepted all of your suggestion. Please give an another pass.

@arajkumar arajkumar merged commit cf0a972 into latest Jun 27, 2025
3 checks passed
@arajkumar arajkumar deleted the arajkumar/refator-lm-instr branch June 27, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesGuthrie JamesGuthrie JamesGuthrie approved these changes

@billy-the-fish billy-the-fish billy-the-fish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arajkumar @JamesGuthrie @billy-the-fish