-
Notifications
You must be signed in to change notification settings - Fork 43
Add Block-Max WAND (BMW) optimization for top-k queries #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
395fed5
Add Block-Max WAND (BMW) optimization for single-term queries
tjgreen42 b7342b3
Add multi-term Block-Max WAND optimization
tjgreen42 ca97cbe
Remove V1 segment fallback from BMW scoring
tjgreen42 30a9e82
Move BMW scoring code to src/query/ directory
tjgreen42 d8e7166
Fix BMW block iteration bug that defeated block skipping
tjgreen42 e67ba58
Batch doc_freq lookups for multi-term queries
tjgreen42 ebd41ea
Use real MS-MARCO dev queries for benchmarks
tjgreen42 f082270
Make MS MARCO load.sql idempotent
tjgreen42 7af8420
Revert load.sql to working version
tjgreen42 43139d5
Fix awk escaping in load.sql
tjgreen42 a3e26fc
Add parallel query benchmark for MS MARCO
tjgreen42 9ad33a3
Remove WAND implementation, keep BMW stats/GUC improvements
tjgreen42 8cbc0a0
Address PR review feedback
tjgreen42 a0eb255
Fix expected output to match updated bmw.sql comment
tjgreen42 8828e63
Remove BMW_MAX_TERMS limit - always use BMW for multi-term queries
tjgreen42 a356889
Update roadmaps with BMW progress and doc-ID traversal limitation
tjgreen42 4bca1d8
Expand BMW limitations note: single-block skipping and doc-ID traversal
tjgreen42 c674f24
Fix BMW review issues and update banner images
tjgreen42 012c0a9
Fix README banner image reference
tjgreen42 230d718
Add test exposing multi-term BMW scoring bug
tjgreen42 045d9c9
Fix multi-term BMW scoring with doc-ID ordered traversal
tjgreen42 6aa75cd
Remove bm25_summarize_index from wand test
tjgreen42 c3c4fe3
Fix wand test: use to_bm25query for explicit index binding
tjgreen42 4a5d5cb
Update ROADMAP: BMW complete with WAND traversal fix
tjgreen42 f4c7268
Fix multi-term BMW crash with 3+ term queries
tjgreen42 8c29a99
Add BMW corner case tests for improved coverage
tjgreen42 acaaa13
Refactor BMW functions into smaller helpers
tjgreen42 dfd6aef
Update banner images
tjgreen42 f23d806
Update banner images
tjgreen42 e87f443
Address PR review comments
tjgreen42 7bb6ef6
Remove redundant WHERE clauses from BMW tests
tjgreen42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes
File renamed without changes
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wanna say I love this Stranger Things-style banner 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aww, I was hoping someone would notice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, the "not yet optimized" tagline is not entirely true anymore, as can be seen from the numbers in the PR description. This little extension is starting to kick some butt.