refactor: move buildphasename/spill_memtable to build.c and remove duplicates #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
commented
Jan 4, 2026
tjgreen42
reviewed
Jan 4, 2026
Collaborator
tjgreen42
left a comment
tjgreen42
left a comment
There was a problem hiding this comment.
I accidentally pushed some commits directly to main, and your PR is an unfortunate victim as it now contains those commits as well. (I've since backed out those commits). Can you clean things up? Thanks for the contributions!
Build phase constants `TP_PHASE_LOADING` and `TP_PHASE_WRITING` were defined in both `am/vacuum.c` and `am/build.c`, so this commit removes the definitions in `am/vacuum.c`. It also moves `tp_buildphasename()` from `am/vacuum.c` to `am/build.c` as it logically belongs there.
SteveLauC
force-pushed
the
chore/duplicate_phasebuild
branch
from
93d9b22 to
b00b651
Compare
Collaborator
Author
Sure :) Done |
tjgreen42
approved these changes
Jan 5, 2026
SteveLauC
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build phase constants
TP_PHASE_LOADINGandTP_PHASE_WRITINGwere defined in botham/vacuum.candam/build.c, so this commit removes the definitions inam/vacuum.c.It also moves
tp_buildphasename()andtp_spill_memtable()fromam/vacuum.ctoam/build.cas they logically belong there.