Skip to content

Replace fixed-size registry with dshash for unlimited indexes #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjgreen42 merged 1 commit into from
Dec 28, 2025
Merged

Replace fixed-size registry with dshash for unlimited indexes #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/mod.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,24 +221,27 @@ tp_object_access(
int subId,
void *arg)
{
(void)arg; /* unused - we don't care about drop flags */

/* Call previous hook if exists */
if (prev_object_access_hook)
prev_object_access_hook(access, classId, objectId, subId, arg);

/* We only care about DROP events on relations (indexes are relations) */
if (access == OAT_DROP && classId == RelationRelationId && subId == 0)
{
ObjectAccessDrop *drop_arg = (ObjectAccessDrop *)arg;

/* Skip internal drops */
if ((drop_arg->dropflags & PERFORM_DELETION_INTERNAL) != 0)
return;
/*
* Always cleanup our indexes regardless of drop flags.
* PERFORM_DELETION_INTERNAL is set for cascade drops (e.g., DROP
* TABLE dropping its indexes) but we still need to free registry
* entries and shared memory in those cases.
*/

/* Check if this is one of our indexes */
if (!tp_registry_is_registered(objectId))
return;

/* Cleanup shared memory BEFORE unregistering */
/* Cleanup shared memory and unregister from registry */
tp_cleanup_index_shared_memory(objectId);
}
}
Expand Down
Loading
Loading