Made jshint more strict (undefined globals)

.jshintrc

@@ -3,5 +3,6 @@
   "expr": true,
   "proto": true,
   "lastsemic": true,
-  "laxbreak": true
+  "laxbreak": true,
+  "strict": false
 }

bin/.jshintrc

@@ -0,0 +1,25 @@
+{
+  "laxcomma": true,
+  "expr": true,
+  "proto": true,
+  "lastsemic": true,
+  "laxbreak": true,
+  "strict": false,
+
+  "undef": true,
+  "browser": true,
+  "globals": {
+
+      "describe": true
+    , "it": true
+    , "afterEach": true
+    , "beforeEach": true
+
+    , "expect": true    
+
+    , "dpd": true
+
+    , "chain": true
+    , "cleanCollection": true
+  }
+}

clib/.jshintrc

@@ -0,0 +1,16 @@
+{
+  "laxcomma": true,
+  "expr": true,
+  "proto": true,
+  "lastsemic": true,
+  "laxbreak": true,
+  "strict": false,
+
+  "undef": true,
+  "browser": true,
+  "devel": true,
+  "globals": {
+      "io": true
+    , "_dpd": true
+  }
+}

clib/dpd.js

@@ -1,3 +1,5 @@
+/*global _dpd:true, io:true*/
+
 (function (undefined) {
 
   if (!window._dpd) window._dpd = {};
@@ -35,7 +37,7 @@
     return parts;
 }
 
-  normalizePath = function(path) {
+  var normalizePath = function(path) {
       var isAbsolute = path.charAt(0) === '/',
           trailingSlash = path.slice(-1) === '/';
 

lib/.jshintignore

@@ -0,0 +1,4 @@
+resources/collection/dashboard
+resources/dashboard
+
+util/uuid.js

lib/.jshintrc

@@ -0,0 +1,11 @@
+{
+  "laxcomma": true,
+  "expr": true,
+  "proto": true,
+  "lastsemic": true,
+  "laxbreak": true,
+  "strict": false,
+
+  "undef": true,
+  "node": true
+}

lib/internal-client.js

@@ -6,7 +6,7 @@ function normalizeArray(parts, allowAboveRoot) {
   for (var i = parts.length - 1; i >= 0; i--) {
     var last = parts[i];
     if (last == '.') {
-      parts.splice(i, 1);
+    parts.splice(i, 1);
     } else if (last === '..') {
       parts.splice(i, 1);
       up++;
@@ -26,7 +26,7 @@ function normalizeArray(parts, allowAboveRoot) {
   return parts;
 }
 
-normalizePath = function(path) {
+var normalizePath = function(path) {
   var isAbsolute = path.charAt(0) === '/',
       trailingSlash = path.slice(-1) === '/';
 

lib/keys.js

@@ -76,7 +76,7 @@ Keys.prototype.writeFile = function(data, fn) {
   try {
     str = JSON.stringify(data);
   } catch(e) {
-    return fn(r);
+    return fn(e);
   }
 
   fs.writeFile(this.path, str, fn);

lib/resources/collection/index.js

@@ -424,7 +424,7 @@ Collection.prototype.save = function (ctx, fn) {
     var id = query.id;
     store.first({id: query.id, $fields: query.$fields}, function(err, obj) {
       if(!obj) return done(new Error('You can\'t update an object that does not exist.'));
-      if(err) return done(rerr);
+      if(err) return done(err);
 
       // merge changes
       Object.keys(item).forEach(function (key) {

make.js

@@ -1,34 +1,40 @@
 require('shelljs/make');
 
-var less = require('less');
+var path = require('path');
 
 target.all = function() {
-  target.dashboard();
+  target.jshint();
 };
 
-target.dashboard = function() {
-  cd(__dirname);
-
-  var lessSource = cat('lib/resources/dashboard/stylesheets/style.less');
-
-  if (lessSource) {
-    var parser = new(less.Parser)({
-      paths: ['lib/resources/dashboard/stylesheets'], // Specify search paths for @import directives
-      filename: 'style.less' // Specify a filename, for better error messages
-    });
+target.jshint = function() {
+  target.jshintLib();
+  target.jshintTest();
+  target.jshintDpdJs();
+  target.jshintCli();
+};
 
-    parser.parse(lessSource, function (e, tree) {
-      if (e) return console.error(e.message);
-      tree.toCSS().to('lib/resources/dashboard/stylesheets/style.css');
-    });
+function hint(pathName, fileName) {
+  var lastPath = process.cwd();
+  cd(pathName);
+  echo("Linting " + pathName + (fileName ? ("/" + fileName) : "") + "...");
+  exec('jshint ' + (fileName || '.'));
+  echo();
+  cd(lastPath);
+}
+
+target.jshintLib = function() {
+  hint('lib');
+};
 
-  }
+target.jshintTest = function() {
+  hint('test');
+  hint('test-app');
+};
 
+target.jshintDpdJs = function() {
+  hint('clib', 'dpd.js');
+};
 
-  // var result = exec('lessc lib/resources/dashboard/stylesheets/style.less', {silent: true});
-  // if (result.code) {
-  //   console.error(result.output);
-  // } else {
-  //   result.output.to('lib/resources/dashboard/stylesheets/style.css')
-  // }
+target.jshintCli = function() {
+  hint('bin', 'dpd');
 };

package.json

@@ -36,7 +36,8 @@
     "chai": "*",
     "node-markdown": "*",
     "dox": "*",
-    "less": "*"
+    "less": "*",
+    "jshint": "*"
   }, 
   "bin": { "dpd": "./bin/dpd" },
   "scripts": {

test-app/.jshintignore

@@ -0,0 +1,5 @@
+node_modules
+public/chai.js
+public/mocha.js
+public/jquery.js
+resources

test-app/.jshintrc

@@ -0,0 +1,25 @@
+{
+  "laxcomma": true,
+  "expr": true,
+  "proto": true,
+  "lastsemic": true,
+  "laxbreak": true,
+  "strict": false,
+
+  "undef": true,
+  "browser": true,
+  "globals": {
+
+      "describe": true
+    , "it": true
+    , "afterEach": true
+    , "beforeEach": true
+
+    , "expect": true    
+
+    , "dpd": true
+
+    , "chain": true
+    , "cleanCollection": true
+  }
+}