changes to SingleOwnerMixin for Django-2.0 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsavage
reviewed
Jan 8, 2018
| owner = models.ForeignKey(USER_MODEL_NAME, verbose_name=_('owner'), | ||
| related_name='%(app_label)s_%(class)s_owner') | ||
| related_name='%(app_label)s_%(class)s_owner', | ||
| on_delete=models.CASCADE, null=True, blank=False) |
There was a problem hiding this comment.
Is there a reason for null=True?
There was a problem hiding this comment.
It's the only way 'makemigrations' would work for me; but perhaps there is a better way?
| if value is not None: | ||
| value = value._amount | ||
| return connection.ops.value_to_db_decimal(value, self.max_digits, self.decimal_places) | ||
| return connection.ops.adapt_decimalfield_value(value, self.max_digits, self.decimal_places) |
There was a problem hiding this comment.
Is this change backwards compatible with Django < 2?
This might require a conditional to handle previous Django releases
There was a problem hiding this comment.
Unfortunately, I don't know, as everything I'm doing now is Django 2+. But it seems that 'value_to_db_decimal' disappeared in Django 1.9
… no attribute 'as_tuple'
timsavage
requested changes
May 17, 2020
|
|
||
|
|
||
| class Money(object): | ||
| class Money(decimal.Decimal): |
There was a problem hiding this comment.
This is not the right solution to this problem. This class composes a money value from a Decimal amount and a currency it does not use inheritance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django-2.0 compatibility