Open
Conversation
timvisher-dd
pushed a commit
that referenced
this pull request
Feb 16, 2026
…townhall#1706) * perf(doctor): fix O(n) full-table scans causing 130s doctor runs Three performance fixes for bd doctor on large databases (23k+ issues): 1. CheckDuplicateIssues (66s → 10ms): Replace SearchIssues() that loaded ALL issues into memory with SQL GROUP BY aggregation. The old code transferred 23k full issue rows (50+ columns) over MySQL wire protocol just to count duplicates. 2. CheckStaleClosedIssues (57s → 4ms): Replace SearchIssues() that loaded ALL closed issues with SELECT COUNT(*) SQL query. Same root cause as #1. 3. ResolvePartialID (60s+ → <1s for missing IDs): The substring search fallback loaded ALL issues when exact match failed. Now passes the hash as a search query to leverage SQL-level id LIKE filtering instead of transferring the entire database to Go for in-memory matching. Total bd doctor runtime: 130s → 6s (22x speedup). Total gt doctor runtime: infinite hang → 15s. Root cause: These checks used store.SearchIssues() which does SELECT id then GetIssuesByIDs() (full row fetch). On Dolt server mode with 23k+ issues, transferring all rows over MySQL wire protocol is catastrophically slow. SQL aggregation and filtering avoid the data transfer entirely. Co-Authored-By: Claude Opus 4.6 <[email protected]> * test(doctor): add 7 missing tests for performance PR CheckStaleClosedIssues (6 tests): - DisabledSmallCount: threshold=0, <10k closed → OK - DisabledLargeCount: threshold=0, ≥10k closed → warning - EnabledWithCleanable: threshold=30d, old issues → correct count - EnabledNoneCleanable: threshold=30d, recent issues → OK - PinnedExcluded: all pinned → 0 cleanable - MixedPinnedAndStale: 5 stale + 3 pinned → reports 5 CheckDuplicateIssues (2 tests): - MultipleDuplicateGroups: 2+ groups → correct groupCount/dupCount - ZeroDuplicatesNullHandling: SUM() NULL → defaults to 0 ResolvePartialID (1 test): - TitleFalsePositive: hash in title but different ID → rejected Co-Authored-By: Claude Opus 4.6 <[email protected]> --------- Co-authored-by: Claude Opus 4.6 <[email protected]>
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
from
943ddba to
0e87fb2
Compare
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
2 times, most recently
from
2259d73 to
0cb0761
Compare
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
2 times, most recently
from
5884656 to
ea9d975
Compare
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
from
ea9d975 to
8128da2
Compare
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
from
8128da2 to
05353f8
Compare
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
from
05353f8 to
d737202
Compare
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
from
d737202 to
459bb07
Compare
Flake lock file updates:
• Updated input 'nixpkgs':
'github:NixOS/nixpkgs/36a6011' (2026-04-04)
→ 'github:NixOS/nixpkgs/10e7ad5' (2026-04-21)
github-actions
Bot
force-pushed
the
update_flake_lock_action
branch
from
459bb07 to
6d235c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by the update-flake-lock GitHub Action.
Running GitHub Actions on this PR
GitHub Actions will not run workflows on pull requests which are opened by a GitHub Action.
To run GitHub Actions workflows on this PR, close and re-open this pull request.