Github Actions: Check, Test & Integration Tests #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging
After merging
Description
PhantomJS was deprecated and access to Travis was unknown so a new setup to make sure we only merge working code.
Playwright End-to-end Tests
I've replaced PhantomJS with Playwright. WordPress is moving more towards using Playwright as the de facto testing tool (source).
Besides this, I've also made it a bit easier to start a local environment using wp-env.
You can see example in the origin:
https://github.com/wcreateweb/wordpress-plugin/actions/workflows/integration-tests.yml
This will be expanded with all the original integration tests. Plan is to adjust the workflow to run on each merge request.
Github Actions
Besides the integration test, I also added a change to run the phpcs style check and the PHPUnit tests before integration tests are run. It will use the same environment and the same scripts as before. I've allowed it to fail as the style changes will make this pull request unreadable.