Open
Conversation
ayashjorden
requested changes
Feb 20, 2026
…ge-level functions
Contributor
Author
|
@ayashjorden Thanks for the review, available for re-review. |
ayashjorden
reviewed
Feb 20, 2026
| @@ -217,6 +218,7 @@ func (s *SQLAdapter) Delete(item any, filter map[string]any, params ...map[strin | |||
| func (s *SQLAdapter) executePaginatedQuery( | |||
Contributor
There was a problem hiding this comment.
Missing godoc, specifically b/c the function has default behavior.
Also, I think that switch-case would be more appropriate than the current defaultValue-if clause
ayashjorden
reviewed
Feb 20, 2026
Comment on lines
+343
to
+353
| func extractSortDirection(paramMap map[string]any) SortingDirection { | ||
| if dir, exists := paramMap[SortDirectionKey]; exists { | ||
| if dirStr, ok := dir.(string); ok { | ||
| switch SortingDirection(strings.ToUpper(dirStr)) { | ||
| case Descending: | ||
| return Descending | ||
| } | ||
| } | ||
| } | ||
| return Ascending | ||
| } |
Contributor
There was a problem hiding this comment.
IMHO, we should be explicit on what we match and return. and return an error otherwise.
Contributor
Author
There was a problem hiding this comment.
Good catch, let me add this
ayashjorden
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding sorting server-side for sql adapter following cosmosdb implementation