-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expectation driven SPI test helper (RFC) #742
base: dev
Are you sure you want to change the base?
Conversation
Very cool, I will take a look! |
We were needing to do something about that probably, however since some drivers do very specific things with
A very good question. Since we do that CS "manually" in the drivers, it probably needs to be somehow separated. |
I added another, very basic expectation based |
Using something like |
This is my WAG at an SPI test helper after I wrote #738
It's based on ordered
Tx
expecations. I also had to make a partialPin
interface as input to my MAX6675, I'm not sure how to finish that out in a meaningful way withoutmachine
. I'm not sure if the chip select pin should be part of the test helper or an independent concern.I'll leave this here as a discussion point, but happy to adjust or expand this as well as try my hand and testing some of the other SPI based drivers to get a feel for the API here.