Added alarm features for DS3231 #758
Conversation
|
@conejoninja PTAL 😸 |
|
it's on my backlog, i'll review it eventually |
There was a problem hiding this comment.
Hello, thanks for your contribution, since you already did the work for Alarm1, does it make sense to add Alarm2 too?
Also, since we are at it, I would add a new example under /examples/ds3231 for the alarms, let's keep the one already as "basic" and another for the alarms. It would be great to show how to set an interrupt on TinyGo.
| @@ -148,6 +149,105 @@ func (d *Device) ReadTime() (dt time.Time, err error) { | |||
| return | |||
| } | |||
|
|
|||
| func (d *Device) GetSqwPinMode() SqwPinMode { | |||
There was a problem hiding this comment.
Exported functions need documentation
| return SqwPinMode(data[0]) | ||
| } | ||
|
|
||
| func (d *Device) SetSqwPinMode(mode SqwPinMode) error { |
There was a problem hiding this comment.
This too, exported functions need documentation
| // ALarm1 Modes | ||
| type Alarm1Mode uint8 | ||
|
|
||
| const ( |
There was a problem hiding this comment.
Shouldn't be add Alarm2 too?
Hi sure can do that stuff, if it's fine around 2-3 weeks as timeline. And of course alarm2, examples, docs will be added. Just wanted to make sure, that the PR will be accepted before doing the whole work :) |
|
Sure, we welcome every contribution, sometimes we are a bit slower reviewing changes, but we eventually get them done. |
I've implemented missing features for DS3231 RTC similar like RTClib
These can be used to set Alarm1 (alarm2 is missing), read alarm1, activate alarm1, use sqw for interrupts, etc.