Skip to content

fix(flows): repair main compile break from crossed PRs#5128

Merged
graycyrus merged 2 commits into
tinyhumansai:mainfrom
senamakel:fix/flows-compile-break
Jul 22, 2026
Merged

fix(flows): repair main compile break from crossed PRs#5128
graycyrus merged 2 commits into
tinyhumansai:mainfrom
senamakel:fix/flows-compile-break

Conversation

@senamakel

Copy link
Copy Markdown
Member

Summary

Problem

Two merged PRs crossed:

Consequences on main:

  • error[E0061] at src/openhuman/flows/ops.rs:4039 — 6 args passed to the 7-arg finish_flow_run_row.
  • With vendor/tinyagents at 1.9.0, the [patch.crates-io] no longer satisfies the root crate's tinyagents = "2.1" requirement, so the dependency graph splits into two tinyagents versions. That yields error[E0308] (tinyflows::engine::GraphObservation vs tinyagents::GraphObservation at ops.rs:3680) and error[E0277] (SqliteCheckpointer<Value>: Checkpointer<Value> not satisfied at src/openhuman/tinyflows/caps.rs:3391 — "multiple different versions of crate tinyagents").

PR branches missed this because the vendor pointer regression only materializes at merge time on main.

Solution

Minimal, two commits:

Cargo.toml/Cargo.lock are untouched — they were already correct; only the gitlinks and one call site drifted.

Submission Checklist

  • Tests added or updated — N/A: compile-break repair; behavior is already pinned by the existing #5114/#5115 flows tests, which could not run while main failed to compile
  • Diff coverage ≥ 80%N/A: one-line call-site fix + submodule pointer restore; exercised by the existing flows_resume tests
  • Coverage matrix updated — N/A: no feature change
  • All affected feature IDs from the matrix are listed in the PR description under ## RelatedN/A: no feature change
  • No new external network dependencies introduced
  • Manual smoke checklist updated — N/A: no release-cut surface touched
  • Linked issue closed via Closes #NNNN/A: no issue filed; fixes the red main run cited above

Impact

Related

  • Closes:
  • Follow-up PR(s)/TODOs: consider a CI guard that fails a PR whose vendor gitlink moves backwards relative to its merge base.

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: fix/flows-compile-break
  • Commit SHA: f03ba0f

Validation Run

  • pnpm --filter openhuman-app format:check — N/A (no frontend change)
  • pnpm typecheck — N/A (no frontend change)
  • Focused tests: N/A (compile repair)
  • Rust fmt/check (if changed): cargo clippy -p openhuman -- -D warnings (the exact CI Lite "Rust Quality" command) passes locally
  • Tauri fmt/check (if changed): N/A (shell untouched)

Validation Blocked

  • command: N/A
  • error: N/A
  • impact: N/A

Behavior Changes

Parity Contract

  • Legacy behavior preserved: yes.
  • Guard/fallback/dispatch parity checks: N/A.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): N/A
  • Canonical PR: N/A
  • Resolution (closed/superseded/updated): N/A

…#5114

PR tinyhumansai#5114 accidentally rolled the vendor submodule gitlinks backwards
(tinyagents v2.1.0 -> v1.9.0, tinyflows to a commit requiring
tinyagents 1.2, plus tinychannels/tinyjuice), splitting the dependency
graph into two tinyagents versions and breaking main (E0308, E0277).
Restore the pointers tinyhumansai#5081 landed.
finish_flow_run_row gained a flow_id parameter in tinyhumansai#5115 (FlowRunFinished
event); the flows_resume compatibility-gate call added in tinyhumansai#5114 was
written against the old 6-arg signature (E0061).
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db50715f-651a-4703-8019-2223143e752a

📥 Commits

Reviewing files that changed from the base of the PR and between 5b8a9f2 and f03ba0f.

📒 Files selected for processing (5)
  • src/openhuman/flows/ops.rs
  • vendor/tinyagents
  • vendor/tinychannels
  • vendor/tinyflows
  • vendor/tinyjuice

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants