fix(flows): repair main compile break from crossed PRs#5128
Conversation
…#5114 PR tinyhumansai#5114 accidentally rolled the vendor submodule gitlinks backwards (tinyagents v2.1.0 -> v1.9.0, tinyflows to a commit requiring tinyagents 1.2, plus tinychannels/tinyjuice), splitting the dependency graph into two tinyagents versions and breaking main (E0308, E0277). Restore the pointers tinyhumansai#5081 landed.
finish_flow_run_row gained a flow_id parameter in tinyhumansai#5115 (FlowRunFinished event); the flows_resume compatibility-gate call added in tinyhumansai#5114 was written against the old 6-arg signature (E0061).
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 44 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
Summary
main(failing run: https://github.com/tinyhumansai/openhuman/actions/runs/29917654044, job "Rust Quality (fmt, clippy)"):error[E0061],error[E0308],error[E0277].tinyagents,tinyflows,tinychannels,tinyjuice) that fix(flows): reject an unknown agent_ref at author time instead of mid-run #5114 accidentally rolled backwards.finish_flow_run_rowcall inflows_resumethat was still on the pre-feat(flows): FlowRunFinished event — fully event-driven runs rail (completes B35) #5115 6-argument signature.Problem
Two merged PRs crossed:
vendor/tinyagentsto v2.1.0,vendor/tinyflowsto a commit requiringtinyagents = "2.1") with the matchingCargo.toml/Cargo.lock.flow_idparameter tofinish_flow_run_row(needed to publishFlowRunFinished), making it 7 arguments.tinyagentsv2.1.0 → v1.9.0,tinyflowsback to a commit requiringtinyagents = "1.2"), and its newflows_resumecompatibility-gate path callsfinish_flow_run_rowwith the old 6-argument shape.Consequences on
main:error[E0061]atsrc/openhuman/flows/ops.rs:4039— 6 args passed to the 7-argfinish_flow_run_row.vendor/tinyagentsat 1.9.0, the[patch.crates-io]no longer satisfies the root crate'stinyagents = "2.1"requirement, so the dependency graph splits into twotinyagentsversions. That yieldserror[E0308](tinyflows::engine::GraphObservationvstinyagents::GraphObservationatops.rs:3680) anderror[E0277](SqliteCheckpointer<Value>: Checkpointer<Value>not satisfied atsrc/openhuman/tinyflows/caps.rs:3391— "multiple different versions of cratetinyagents").PR branches missed this because the vendor pointer regression only materializes at merge time on
main.Solution
Minimal, two commits:
vendor/tinyagents2583fcc (v2.1.0),vendor/tinyflows56998ec,vendor/tinychannels14057e0,vendor/tinyjuicee6848ed. This re-unifies the graph on onetinyagents 2.1.0and fixes E0308/E0277 with zero code change.flow_id(already in scope and semantically correct — it is the flow whose resume was rejected) to thefinish_flow_run_rowcall inflows_resume, matching every other call site updated by feat(flows): FlowRunFinished event — fully event-driven runs rail (completes B35) #5115.Cargo.toml/Cargo.lockare untouched — they were already correct; only the gitlinks and one call site drifted.Submission Checklist
N/A: compile-break repair; behavior is already pinned by the existing #5114/#5115 flows tests, which could not run while main failed to compileN/A: one-line call-site fix + submodule pointer restore; exercised by the existing flows_resume testsN/A: no feature change## Related—N/A: no feature changeN/A: no release-cut surface touchedCloses #NNN—N/A: no issue filed; fixes the red main run cited aboveImpact
mainCI (Rust Quality lane and everything downstream of a compiling core crate).flows_resumecompatibility gate now carry the correctflow_id.Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/flows-compile-breakValidation Run
pnpm --filter openhuman-app format:check— N/A (no frontend change)pnpm typecheck— N/A (no frontend change)cargo clippy -p openhuman -- -D warnings(the exact CI Lite "Rust Quality" command) passes locallyValidation Blocked
command:N/Aerror:N/Aimpact:N/ABehavior Changes
Parity Contract
Duplicate / Superseded PR Handling