[codex] Add context-preserving invoke stream#21
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
tinyagents/src/harness/agent_loop/stream.rs
Line 136 in 285dfe7
Avoid leaking stream listeners on shared EventSink
When callers pass a RunContext that was built with a long-lived/shared EventSink via with_events, this one-shot channel listener is appended to that sink permanently; EventSink::subscribe stores listeners in its internal Vec and there is no unsubscribe path. After the returned stream completes or is dropped, the receiver is gone but the sender remains in the shared sink, so repeated invoke_stream_in_context runs leak listeners and make every later emit clone/send to dead channels.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a788b85500
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // clone, so their lifecycle events reach this stream too. | ||
| ctx.events.subscribe(Arc::new(ChannelListener { tx })); | ||
| let listener: Arc<dyn EventListener> = Arc::new(ChannelListener { tx }); | ||
| ctx.events.subscribe(listener.clone()); |
There was a problem hiding this comment.
When ctx.events is a long-lived/shared sink, this subscribes the stream listener before this run future has been polled. The unfold below uses a biased select that drains rx.recv() before polling run_fut, so events emitted by another active run or host component on the same sink can keep this stream yielding unrelated records and prevent this run from starting or completing. Consider isolating/filtering the listener to this run or ensuring the run future is polled even while the shared sink is busy.
Useful? React with 👍 / 👎.
1 participant
Summary
Adds
AgentHarness::invoke_stream_in_context, a caller-consumable streaming entry point that preserves a caller-suppliedRunContext.invoke_streamstill constructs a fresh context for the simple case, but now delegates to the context-preserving method. This lets host integrations attach cancellation, events, stores, workspace metadata, or steering before driving the stream.Validation
cargo fmt --checktimeout 180s cargo clippy --all-targets -- -D warningstimeout 120s cargo test invoke_stream_in_context_preserves_caller_contextFull CI is left to GitHub runners.