[codex] Add provider failure classification helpers#24
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f1b5e7aba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| _ => message.to_ascii_lowercase(), | ||
| }; | ||
|
|
||
| if status == Some(429) || text_indicates_rate_limit(&lower) { |
There was a problem hiding this comment.
When this helper is called from SseState::stream_error it passes status: None, so a streamed error whose code/message is insufficient_quota, quota exhausted, out of credits, or provider code 1311 does not enter this branch unless the text also contains 429/rate-limit wording. It then skips the non-retryable-rate-limit check and falls through to ProviderFailureClass::Retryable, causing the agent retry/fallback loops to repeat permanent billing/plan failures. Check text_indicates_non_retryable_rate_limit before gating on status == Some(429)/rate-limit text.
Useful? React with 👍 / 👎.
| for (idx, _) in message.match_indices('(') { | ||
| if let Some(status) = parse_status_at(message, idx + 1) { | ||
| return Some(status); | ||
| } |
There was a problem hiding this comment.
For statusless provider messages, this loop treats every (...) value that starts with exactly three digits as an HTTP status. A validation error such as invalid embedding dimension (512) or max_tokens (500) exceeds the limit is therefore classified as a 5xx UpstreamUnhealthy and marked retryable, even though no HTTP status was present; this affects streamed errors because they call the classifier with status: None. Restrict the parenthesized parse to known envelopes like API error ( or require an explicit HTTP/status marker.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation