Fail an empty provider completion instead of a blank final answer#40
Conversation
Add an opt-in RunPolicy.error_on_empty_response guard: when set, an assistant completion with no text, no tool calls, and no structured output in the finalization branch drops the empty row and returns a typed TinyAgentsError::EmptyResponse rather than terminating the run with a blank success. Defaults off to preserve existing callers. Closes tinyhumansai/openhuman#4638
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
Comment |
collapsible_if in StreamAccumulator::push_tool_chunk and a duplicated #[cfg(test)] on the stream test module both fail CI's cargo clippy --all-targets -- -D warnings under rust 1.96. Behavior-neutral.
|
CI guardian: the |
Add an opt-in
RunPolicy.error_on_empty_responseguard. When enabled, an assistant completion with no text, no tool calls, and no structured output in the agent-loop finalization branch drops the empty row and returns a typedTinyAgentsError::EmptyResponseinstead of terminating the run with a blank final answer. Defaults tofalse, preserving behavior for callers that rely on empty finals.Validated:
cargo fmt;cargo test --lib(997 passed, incl. 2 new tests covering guard-on/guard-off).Note:
cargo clippy --lib --tests -- -D warningsreports one pre-existingcollapsible_iflint atsrc/harness/model/mod.rs:756(untouched by this PR; reproduces onmainwith these changes stashed, tripped by clippy 1.96.1). With that single pre-existing lint allowed, clippy is clean — this change introduces no new warnings.Closes tinyhumansai/openhuman#4638