feat: make remote code execution configurable via env var#397
Open
Yaduttam95 wants to merge 1 commit intotirth8205:mainfrom
Open
feat: make remote code execution configurable via env var#397Yaduttam95 wants to merge 1 commit intotirth8205:mainfrom
Yaduttam95 wants to merge 1 commit intotirth8205:mainfrom
Conversation
…dependencies in uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛡️ Security: Fix Remote Code Execution (RCE) vulnerability in embeddings
Overview
This document summarizes the security fix implemented to prevent potential Remote Code Execution (RCE) when loading local embedding models.
The Issue
The
LocalEmbeddingProviderwas previously configured to instantiateSentenceTransformerwith thetrust_remote_code=Trueflag hardcoded.Risk Level: Critical
The Solution
We have implemented a "Secure by Default" policy for model loading.
1. Disabled Default Trust
The hardcoded
trust_remote_code=Truehas been removed. The application now defaults toFalse, which prevents the execution of any untrusted code bundled with a model.2. Introduced Explicit Opt-in
Users who intentionally need to use models that require custom remote code can now do so via a new environment variable:
CRG_ALLOW_REMOTE_CODE1,true, oryes0(Disabled)3. Implementation Details
The fix was applied in
code_review_graph/embeddings.py. The logic now checks the environment variable before passing the flag to theSentenceTransformerconstructor: