Skip to content

fix: add encoding='utf-8' to subprocess.run() calls to fix Windows non-UTF-8 locale #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suainam wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

fix: add encoding='utf-8' to subprocess.run() calls to fix Windows non-UTF-8 locale #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions code_review_graph/incremental.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ def _git_branch_info(repo_root: Path) -> tuple[str, str]:
result = subprocess.run(
["git", "rev-parse", "--abbrev-ref", "HEAD"],
capture_output=True,
text=True,
text=True, encoding='utf-8',
cwd=str(repo_root),
timeout=_GIT_TIMEOUT,
)
Expand All @@ -345,7 +345,7 @@ def _git_branch_info(repo_root: Path) -> tuple[str, str]:
result = subprocess.run(
["git", "rev-parse", "HEAD"],
capture_output=True,
text=True,
text=True, encoding='utf-8',
cwd=str(repo_root),
timeout=_GIT_TIMEOUT,
)
Expand Down Expand Up @@ -424,7 +424,7 @@ def get_changed_files(repo_root: Path, base: str = "HEAD~1") -> list[str]:
result = subprocess.run(
["git", "diff", "--name-only", base, "--"],
capture_output=True,
text=True,
text=True, encoding='utf-8',
cwd=str(repo_root),
timeout=_GIT_TIMEOUT,
)
Expand All @@ -433,7 +433,7 @@ def get_changed_files(repo_root: Path, base: str = "HEAD~1") -> list[str]:
result = subprocess.run(
["git", "diff", "--name-only", "--cached"],
capture_output=True,
text=True,
text=True, encoding='utf-8',
cwd=str(repo_root),
timeout=_GIT_TIMEOUT,
)
Expand Down Expand Up @@ -496,7 +496,7 @@ def get_staged_and_unstaged(repo_root: Path) -> list[str]:
result = subprocess.run(
["git", "status", "--porcelain"],
capture_output=True,
text=True,
text=True, encoding='utf-8',
cwd=str(repo_root),
timeout=_GIT_TIMEOUT,
)
Expand Down Expand Up @@ -541,7 +541,7 @@ def get_all_tracked_files(
result = subprocess.run(
cmd,
capture_output=True,
text=True,
text=True, encoding='utf-8',
cwd=str(repo_root),
timeout=_GIT_TIMEOUT,
)
Expand Down