Skip to content

Add GitHub Actions config file - #1027

Merged
abetomo merged 1 commit into
tj:developfrom
abetomo:add_github_actions_config_file
Aug 30, 2019
Merged

Add GitHub Actions config file#1027
abetomo merged 1 commit into
tj:developfrom
abetomo:add_github_actions_config_file

Conversation

@abetomo

@abetomo abetomo commented Aug 23, 2019

Copy link
Copy Markdown
Collaborator

You can also test on Windows.

Pull Request

Problem

We were not using Windows CI.

Solution

Use GitHub Actions to test on Windows.

ChangeLog

@shadowspawn

Copy link
Copy Markdown
Collaborator

Nice! I will research a bit about Github Actions before reviewing.

(There will likely be some minor code changes to get current tests running and passing on Windows: #916 )

@shadowspawn

Copy link
Copy Markdown
Collaborator

3.0.1 is out, so keen to give this a go! (Did you sign up for the beta?)
I expect the Windows build will break, but that is ok.
Not sure if this will be active from develop branch, but will try that first.

Thanks @abetomo. I was thinking of the Azure PR we got a while ago but I like this better.

@shadowspawn shadowspawn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to call it tests.yml?

@shadowspawn

Copy link
Copy Markdown
Collaborator

I'll let you do the merge @abetomo. Keen to see what happens. 🙂

@abetomo
abetomo force-pushed the add_github_actions_config_file branch 2 times, most recently from 585b33e to dcbd62f Compare August 30, 2019 09:21
@abetomo
abetomo force-pushed the add_github_actions_config_file branch from dcbd62f to 977db09 Compare August 30, 2019 09:23
@abetomo

abetomo commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator Author

Renamed the configuration file, and fixed the problem with the settings.

This was the result for my repository.
https://github.com/abetomo/commander.js/runs/207808904

This repository is also valid, so it will work if merged.

@abetomo
abetomo merged commit 9e39227 into tj:develop Aug 30, 2019
@abetomo
abetomo deleted the add_github_actions_config_file branch August 30, 2019 09:33
@abetomo

abetomo commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator Author

https://github.com/tj/commander.js/runs/207817593
It seems that this repository worked when merged with develop.

@shadowspawn

Copy link
Copy Markdown
Collaborator

Nice! How do you see the runs? (When I go to Actions I just see templates, but I can follow your link and see that run.)

@abetomo

abetomo commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator Author

Probably, you can see it from the 'Actions' tab once it has been merged with master.

@shadowspawn

Copy link
Copy Markdown
Collaborator

I have signed up for the Actions beta, I might be able to see more when accepted.

It does not look like the test are running on Windows, but I was not sure why on first look.

(Woop woop! Thanks.)

@abetomo

abetomo commented Aug 30, 2019

Copy link
Copy Markdown
Collaborator Author

It's hard to see in the capture, but it seems to work on Windows.

スクリーンショット 2019-08-30 18 53 34

@shadowspawn shadowspawn added the pending release Merged into a branch for a future release, but not released yet label Aug 30, 2019
@shadowspawn

Copy link
Copy Markdown
Collaborator

I got added to the beta program, and can see the past workflow runs now. I am still suspicious whether the Windows test are running but clearly they are meant to. Looking forward to merging with the Jest branch. Exciting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants