Remove trailing blanks from wrapped help text - #1096
Merged
Conversation
Collaborator
|
I'll do some testing, but looks sensible, and I like that it removes (invisible) trailing spaces from the unit tests. |
shadowspawn
approved these changes
Nov 15, 2019
shadowspawn
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
(My terminal does not show the wrapping problem before the fix, but I think it is allowing an extra character so I missed the problem. I like removing the invisible character so WYSIWYG.)
Collaborator
|
4.1 has shipped, thanks @chdh |
This was referenced Feb 25, 2020
This was referenced Mar 14, 2020
This was referenced Jul 22, 2024
This was referenced Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem
Auto-wrapped lines in the generated help text have an extra space character at the end. This leads to unwanted empty lines in the help text display at the console, when a resulting line is exactly 80 characters long.
The trailing space characters can be seen in the changes of this PR for tests/helpwrap.test.js.
Solution
A trimRight() is added in wrap().