-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of Redis JSON #421
base: master
Are you sure you want to change the base?
Conversation
…jects compatible with Redis Stack.
workflow_dispatch added
Hey @otchilin, thanks for working on this and bringing to my attention. Do you have resources that explains the benefits of this approach? Maintaining this project now for multiple years and being a user for many before that, I haven't seen any real issues with the storage mechanism in place. I get it is a neat feature that does have benefits but not seeing its benefits for this project yet. Is this widely available? Why did you have to switch to redis-stack-server to test it? |
Hi @wavded, And since I don't have a reference to the sessions, I would have to search in all the existing sessions those where I find the corresponding user id. And then, it seems natural to store JSON objects in a storage that supports this format 😉 Concerning the test, I've introduced redis stack server because it supports the json plugin and it's necessary to test the new behavior. So nothing revolutionary but a little plus for those who would like to take advantage of the power of the Redis JSON plugin. |
Thanks for the explanation. We do have the My gut is to keep this PR around and the concept out there as a possibility and see if the need grows/more use cases come out. |
+1 for the ability to search and destroy sessions based on some query / around session KV pairs. |
Hi,
As Redis is now supporting JSON, it will be great to also store the session data directly in this format.
This will allows for example to create indexes and find sessions easily against some details as user id or whatever you want. And this is much more optimized than SCAN/MGET over a prefix.
So I propose a small enhancement to add this option (useRedisJson) which is disabled by default to keep standard behavior if not configured.
I've also reworked the build workflow to run test over redis-stack-server under Ubuntu 20.04 which support it via the redis repo.
Hope it will help...
Regards,