New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a more generic callback type that returns `unknown` instead of `void` #426

Open

nicu-chiciuc wants to merge 1 commit into tj:master from nicu-chiciuc:void-to-unknown

+3 −1

nicu-chiciuc commented Mar 14, 2025

The package has implicit type for get, all, etc.

The type of get is inferred as:

(method) RedisStore.get(sid: string, cb?: (_err?: unknown, _data?: any) => void): Promise<void>

Whereas based on the implementation the get can be awaited and a value can be returned.

A better approach would've been to use generics, but for now a simple change to unknown from void is more than acceptable.


          Define a more generic callback type that returns unknown instead of…

a3c31a9

… `void`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet