Added autoconfiguration support #232
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdworak37
commented
Feb 8, 2023
|
|
||
| <groupId>net.kaczmarzyk</groupId> | ||
| <artifactId>sar-spring-boot-starter</artifactId> | ||
| <version>1.0.0-SNAPSHOT</version> |
Contributor
Author
There was a problem hiding this comment.
Autoconfiguration pom has different version than main pom, but in order to keep the same version for both I would have to create another "core" module and move whole main code base to it. In other case I can't add it as a dependency in this pom. Should I do it?
Contributor
Author
There was a problem hiding this comment.
https://stackoverflow.com/questions/10024320/maven-include-parent-classes <--- additional info on solution to this problem
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+224
to
+228
| <repository> | ||
| <id>kaczmarzyk.net</id> | ||
| <name>kaczmarzyk.net repository</name> | ||
| <url>ftp://repo.kaczmarzyk.net</url> | ||
| </repository> |
Check failure
Code scanning / CodeQL
Failure to use HTTPS or SFTP URL in Maven artifact upload/download
Comment on lines
+229
to
+233
| <snapshotRepository> | ||
| <id>kaczmarzyk.net</id> | ||
| <name>kaczmarzyk.net repository</name> | ||
| <url>ftp://repo.kaczmarzyk.net</url> | ||
| </snapshotRepository> |
Check failure
Code scanning / CodeQL
Failure to use HTTPS or SFTP URL in Maven artifact upload/download
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.