-
Notifications
You must be signed in to change notification settings - Fork 44
misc: CSS improvements #1103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: CSS improvements #1103
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2eebd7f:
|
b005d6f to
26f6e65
Compare
c2b167e to
ca771bd
Compare
moe-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for fixing up the documentation as well!
0dc27e2 to
2eebd7f
Compare
|
@moe-dev see 2eebd7f; it corresponds to SDK PR's commit 3c5dde8def4f52db4af1a588bbfcb9b8f51aff76 |
Summary & Motivation
$title
Update the iframe-stamper and export-and-sign iframe (in this frames PR: tkhq/frames#92)
How I Tested These Changes
Locally via
examples/export-and-signandexamples/with-solana-- the former for the UX (interacting with the iframe -- exporting and signing), and the latter to construct the transaction and broadcast the signed transaction.Additional tests:
Did you add a changeset?
Yes
If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run
pnpm changeset.pnpm changesetwill generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.