Skip to content

Conversation

@andrewkmin
Copy link
Collaborator

@andrewkmin andrewkmin commented Nov 22, 2025

Summary & Motivation

$title

Update the iframe-stamper and export-and-sign iframe (in this frames PR: tkhq/frames#92)

How I Tested These Changes

Locally via examples/export-and-sign and examples/with-solana -- the former for the UX (interacting with the iframe -- exporting and signing), and the latter to construct the transaction and broadcast the signed transaction.

Additional tests:

  • Old SDKs against new frames
  • New SDKs against old (current) frames: keys are one time use
  • New SDKs against new frames

Did you add a changeset?

Yes

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 22, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2eebd7f:

Sandbox Source
@turnkey/example-react-components Configuration

@andrewkmin andrewkmin force-pushed the andrew/css-improvements branch from b005d6f to 26f6e65 Compare November 25, 2025 03:42
@andrewkmin andrewkmin changed the title Andrew/css improvements misc: CSS improvements Nov 25, 2025
@andrewkmin andrewkmin force-pushed the andrew/css-improvements branch from c2b167e to ca771bd Compare November 25, 2025 05:11
moe-dev
moe-dev previously approved these changes Nov 25, 2025
Copy link
Contributor

@moe-dev moe-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing up the documentation as well!

@andrewkmin andrewkmin marked this pull request as ready for review November 26, 2025 18:13
@andrewkmin andrewkmin force-pushed the andrew/css-improvements branch from 0dc27e2 to 2eebd7f Compare November 27, 2025 02:25
@andrewkmin
Copy link
Collaborator Author

andrewkmin commented Nov 27, 2025

@moe-dev see 2eebd7f; it corresponds to SDK PR's commit 3c5dde8def4f52db4af1a588bbfcb9b8f51aff76

@andrewkmin andrewkmin merged commit 733e312 into main Nov 27, 2025
13 checks passed
@andrewkmin andrewkmin deleted the andrew/css-improvements branch November 27, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants