Skip to content

Fix #65 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylebutts wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #65 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[tool]
[tool.poetry]
name = "pytwoway"
version = "0.3.21"
version = "0.3.22"
description = "Estimate two way fixed effect labor models"
classifiers = ["Programming Language :: Python :: 3", "License :: OSI Approved :: MIT License", "Operating System :: OS Independent"]
homepage = "https://github.com/tlamadon/pytwoway"
Expand Down
6 changes: 3 additions & 3 deletions pytwoway/preconditioners/ichol.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def _ichol(
a = np.zeros(n, np.float64) # Values of column j
r = np.zeros(n, np.float64) # r[j] = sum(abs(A[j:, j])) for relative threshold
b = np.zeros(
n, np.bool8
n, np.bool
) # b[i] indicates if the i-th element of column j is non-zero
c = np.empty(n, np.int64) # Row indices of non-zero elements in column j
d = np.full(n, shift, np.float64) # Diagonal elements of A
Expand Down Expand Up @@ -206,7 +206,7 @@ def ichol(
relative_discard_threshold: float
Values with an absolute value of less than :code:`relative_discard_threshold * sum(abs(A[j:, j]))` will be discarded.
A dense ichol implementation with relative threshold would look like this::

L = np.tril(A)
for j in range(n):
col = L[j:, j]
Expand All @@ -218,7 +218,7 @@ def ichol(

diag_keep_discarded: bool
Whether to update the diagonal with the discarded values. Usually better if :code:`True`.

Returns
-------
chol: CholeskyDecomposition
Expand Down