Improve handling of Transfer-Encoding errors #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th4s
approved these changes
Nov 25, 2024
sinui0
requested changes
Nov 25, 2024
spansy/src/http/span.rs
Outdated
| )) | ||
| let bad_values = request | ||
| .headers_with_name("Transfer-Encoding") | ||
| .map(|h| std::str::from_utf8(h.value.0.as_bytes()).unwrap_or("")) |
There was a problem hiding this comment.
unwrap_or("") will be misleading if the header value is not value utf8. Better to return a parse error indicating that.
There was a problem hiding this comment.
Instead of returning a parse error, which might be more confusing in this case, I've updated it to use the string {invalid utf-8} in the error message, to signify that the header value cannot be parsed as utf-8. I'm of the mind that it's clearer that way.
…-8. Interpolate bad values directly into error message
TheFrozenFire
force-pushed
the
fix/transfer-encoding-error-clarity
branch
from
b78d6ba to
60472fc
Compare
I've run it just now for the one rust file I changed. When I run it for the repo or crate, it produces a lot of unrelated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transfer-Encoding errors are currently very opaque. This change updates the logic to allow for
Transfer-Encoding: identity(the effective default), and add the incorrect values to the error message to make it easier to troubleshoot bad Transfer-Encoding values.An example of the new error message:
parsing error: Transfer-Encoding other than identity not supported yet: "chunked"