Skip to content

fix(proxy): ensure CORS headers are set #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vbehar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(proxy): ensure CORS headers are set #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion scripts/cors-proxy-server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ const handler = async (req, res) => {

res.statusCode = upstream.status;

// Copy response headers (but keep our CORS headers)
// Copy response headers
upstream.headers.forEach((value, key) => {
const lower = key.toLowerCase();
if (lower === "set-cookie") return;
Expand All @@ -389,6 +389,15 @@ const handler = async (req, res) => {

// Content-Length can be wrong after decompression; let Node set it.
if (lower === "content-length") return;

// Keep our CORS headers.
if (lower === "access-control-allow-origin") return;
if (lower === "access-control-allow-methods") return;
if (lower === "access-control-allow-headers") return;
if (lower === "access-control-expose-headers") return;
if (lower === "access-control-max-age") return;
if (lower === "vary") return;

res.setHeader(key, value);
});

Expand Down