fix(temp_window): Remove non-functional *args parameter #619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
*argsfromtemp_window()signature since it cannot be forwarded toSession.new_window()Problem
Session.new_window()uses keyword-only arguments (has a*marker afterwindow_name), which means it cannot accept positional arguments beyondwindow_name. However,temp_window()accepted*argsand attempted to forward them, which would cause aTypeErrorat runtime if anyone tried to pass positional arguments.Example that would fail before this fix:
Note:
temp_session()is unaffected becauseServer.new_session()explicitly accepts*args.Test plan